Merged
Conversation
- Error: SA1019: gitLabAPI.OwnerPermission is deprecated: Renamed to OwnerPermissions. (staticcheck)
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
raghavaggarwal2308
referenced
this pull request
Mar 11, 2024
…s, and disallow guests from creating subscriptions (#376) * [MI-3045]: Added checks for confidential issues at the time of making subscriptions (#37) * [MI-3045]:Added checks for confidential issues * [MI-3045]:Added unit test cases * [MI-3045]:Fixed self review comments * [MI-3045]:Fixed unit test cases * [MI-3045]:Fixed lint errors * [MI-3045]:Fixed review comments * [MI-3045]:Fixed context deadline error * [MI-3045]:Fixed review comments * [MI-3045]:Fixed statements * [MI-3060]:Fixed review comments of PR #376 on gitlab plugin (#38) * [MI-3060]:Fixed review comments of PR #376 on gitlab plugin * [MI-3060]:Fixed test cases * [MI-3060]:Updated the msg * [MI-3060]:Fixed the test cases * [MM-326]:fixed test cases * [MM-326]:Fixed CI error * [MM-326]:Fixed review comments * [MM-326]:Fixed review comments --------- Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 34.02% 34.02%
=======================================
Files 22 22
Lines 4021 4021
=======================================
Hits 1368 1368
Misses 2515 2515
Partials 138 138 ☔ View full report in Codecov by Sentry. |
hanzei
approved these changes
Mar 11, 2024
mickmister
approved these changes
Mar 11, 2024
mickmister
added
4: Reviews Complete
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
FIxes: 54a9c46#r139610896