Skip to content

436 utils folder typescript migration#442

Merged
mickmister merged 3 commits intomattermost:masterfrom
titanventura:436-utils-folder-typescript-migration
Jan 22, 2024
Merged

436 utils folder typescript migration#442
mickmister merged 3 commits intomattermost:masterfrom
titanventura:436-utils-folder-typescript-migration

Conversation

@titanventura
Copy link
Copy Markdown
Contributor

Summary

Relevant issue #436

  1. Migrated other files under utils directory to Typescript
  2. Added tests for missing file
  3. Removed user_utils.js file since it was unused.

@mickmister mickmister requested a review from ayusht2810 January 17, 2024 15:51
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6c752) 33.40% compared to head (5184df7) 33.40%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   33.40%   33.40%           
=======================================
  Files          22       22           
  Lines        3979     3979           
=======================================
  Hits         1329     1329           
  Misses       2519     2519           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister added the 4: Reviews Complete All reviewers have approved the pull request label Jan 22, 2024
@mickmister mickmister merged commit eab8193 into mattermost:master Jan 22, 2024
This was referenced Jan 24, 2024
@hanzei hanzei added this to the v1.8.1 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants