refactor. migrated date_utils file to typescript, add tests#440
Merged
mickmister merged 1 commit intomattermost:masterfrom Jan 16, 2024
Merged
Conversation
Signed-off-by: titanventura <aswath7862001@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
=======================================
Coverage 33.40% 33.40%
=======================================
Files 22 22
Lines 3979 3979
=======================================
Hits 1329 1329
Misses 2519 2519
Partials 131 131 ☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Jan 16, 2024
Contributor
mickmister
left a comment
mickmister
left a comment
There was a problem hiding this comment.
Thanks for this contribution @titanventura!
| @@ -1,49 +0,0 @@ | |||
| export function formatDate(date, useMilitaryTime = false) { | |||
Contributor
There was a problem hiding this comment.
Interesting. This function was indeed not used anywhere. Thanks for removing this dead code 👍
This was referenced Jan 24, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relevant issue #436
date_utilsfile to Typescriptdate_utilsfileformatDate