[MM-35] Update plugin with respect to phase 1 upgrades

[ayusht2810]

Summary

Updated plugin with respect to phase 1 upgrades

• Updated Makefile
• Updated version in nvmrc file and update package-lock.json file.
• Updated developer docs link in the readme file

Ticket Link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60d1605) 33.53% compared to head (9305bc3) 33.53%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files          22       22           
  Lines        3996     3996           
=======================================
  Hits         1340     1340           
  Misses       2523     2523           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mickmister]

Thanks for these updates @ayusht2810 👍 I have two remaining requests on this. I've updated the doc to reflect this as well https://docs.google.com/document/d/12IoQTHxFHc7yvM-oxPrBTx_LWW6lDVVego8TWkBOQE0/edit

[ayusht2810]

@mickmister fixed the review comments. Please re-review.

[mickmister]

Awesome LGTM 👍

[mickmister]

What's the result when we run npm run check-types right now? Maybe the errors we can take care of while this is open? That way the project is ready to be worked on with other typescript contributions. No worries if you think it doesn't make sense to do that in this PR

[ayusht2810]

@mickmister On adding the above script, we were getting various errors. So I think we can do that in another PR.

[AayushChaudhary0001]

Tested for all the basic features and functionalities, working fine for all of them. Nothing seems to break, approved.

[mickmister]

@ayusht2810 Heads up that there are linting issues to resolve here

Note that for the no-use-before-define rule, we can just disable it in webapp/.eslintrc.json, since the @typescript-eslint/no-use-before-define rule already takes care of this. This is a known issue with this eslint rule working with typescript. To disable the rule you can just set this value:

mattermost-plugin-gitlab/webapp/.eslintrc.json

Lines 380 to 387 in ee780c1

	"no-use-before-define": [
	2,
	{
	"classes": false,
	"functions": false,
	"variables": false
	}
	],

to

"no-use-before-define": "off"

---

I think we can modify the camelcase rule with ignoreDestructuring: true https://eslint.org/docs/latest/rules/camelcase#ignoredestructuring-true

---

The import/order rules and many others can be resolved by running npm run fix

---

For the import/no-unresolved, I think this solution may work https://stackoverflow.com/a/57678771

[ayusht2810]

@mickmister fixed the lint errors and typescript errors.

I think we can modify the camelcase rule with ignoreDestructuring: true

Regarding the camelcase issue in the plugin, I tried to fix it by applying the above rule, but I was still getting camelcase lint errors in the plugin. For now, I have disabled the rule. Let me know your thoughts on this issue.

[mickmister]

@ayusht2810 Disabling the camelCase rule sounds fine to me. Thanks for looking into that

[mickmister]

Are we able to include the latest PRs from the starter template like mattermost/mattermost-plugin-starter-template#192, or would you prefer to do them in a separate PR? A separate PR probably makes sense to minimize scope and get these merged.

I wonder if we can have an automated process to cherry-pick starter template PRs into plugin projects. That would make keeping things up-to-date a lot easier. We could batch them with multiple cherry-picks in one PR if we wanted to as well.

[mickmister]

LGTM, great work @ayusht2810 🚀