Skip to content

[MM-320] Added config setting to enable/disable child pipeline notification#409

Merged
mickmister merged 4 commits intomattermost:masterfrom
Brightscout:MM-320
Dec 6, 2023
Merged

[MM-320] Added config setting to enable/disable child pipeline notification#409
mickmister merged 4 commits intomattermost:masterfrom
Brightscout:MM-320

Conversation

@raghavaggarwal2308
Copy link
Copy Markdown

Summary

When a pipeline with many child pipelines is triggered on Gitlab and the user has a subscription for "pipeline" in a channel, the channel gets flooded with many notifications. We added a config setting to enable/disable notification for child pipelines.
image

Screenshots

When enabled:
image

When disabled:
image

What to test?

  • Not getting notifications for child pipelines when config setting EnableChildPipelineNotifications is disabled.
Steps to reproduce:
  1. Connet your Gitlab account.
  2. Create a subscription for "pipeline" in a channel.
  3. Set up a child pipeline workflow on the project you have created a subscription for. (How to setup child pipeline)
  4. Trigger the pipeline and wait for it to complete.
Environment:

MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0

Ticket Link

Fixes #320

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7190bfd) 32.91% compared to head (6e8247f) 33.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   32.91%   33.08%   +0.17%     
==========================================
  Files          22       22              
  Lines        4017     4020       +3     
==========================================
+ Hits         1322     1330       +8     
+ Misses       2564     2559       -5     
  Partials      131      131              
Files Coverage Δ
server/configuration.go 33.33% <ø> (ø)
server/webhook.go 43.71% <100.00%> (+3.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308 raghavaggarwal2308 changed the title [MI-3589] Added config setting to enable/disable child pipeline notfication [MM-320] Added config setting to enable/disable child pipeline notification Oct 11, 2023
@Kshitij-Katiyar Kshitij-Katiyar self-requested a review October 11, 2023 15:12
Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com>
@hanzei hanzei requested review from AayushChaudhary0001 and removed request for spirosoik November 29, 2023 12:17
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Nov 29, 2023
@avas27JTG avas27JTG added this to the v1.8.0 milestone Dec 5, 2023
Copy link
Copy Markdown

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved
Working fine for both "True" and "False" condition, LGTM.

@mickmister mickmister merged commit 848d1da into mattermost:master Dec 6, 2023
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-320 branch December 6, 2023 08:39
@mickmister mickmister mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: QA Review Requires review by a QA tester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child Pipelines with manual jobs are posted multiple times

6 participants