[GH-61]: Add tooltip for pull request and issue links by shivamjosh · Pull Request #301 · mattermost/mattermost-plugin-gitlab

shivamjosh · 2022-06-06T12:05:06Z

Summary

This PR adds a tooltip for the pull requests and issue links.

Screenshots:
Issue tooltip:

Merge request tooltip:

Ticket Link

#61

MI-1845: Added tooltip for pull request and issue links

mattermod · 2022-06-06T12:05:10Z

Hello @shivamjosh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

…failing CI

…in-gitlab into link_tooltip

codecov · 2022-06-06T13:17:23Z

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (c56accf) 33.61% compared to head (424eec9) 33.25%.

Files	Patch %	Lines
server/api.go	4.16%	46 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   33.61%   33.25%   -0.36%     
==========================================
  Files          22       22              
  Lines        3924     3972      +48     
==========================================
+ Hits         1319     1321       +2     
- Misses       2474     2520      +46     
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webapp/src/components/link_tooltip/link_tooltip.jsx

pvev · 2022-06-15T12:40:00Z

webapp/src/components/link_tooltip/link_tooltip.jsx

+                        >
+                            {data.repo}
+                        </a>
+                        &nbsp;on&nbsp;<span>{date}</span>


what do you thing about setting the space using css instead of &nbsp?

Added CSS styling.

Alternatively, I think it can be implemented as:

</a> {' on '} <span>{date}</span>

@mickmister Updated

webapp/src/components/link_tooltip/link_tooltip.jsx

pvev

thanks @shivamjosh , nice work!

…in-gitlab into link_tooltip

mattermost-build · 2023-04-30T01:01:48Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

raghavaggarwal2308 · 2023-04-30T08:45:25Z

@DHaussermann Gentle reminder for review

…ab into link_tooltip

raghavaggarwal2308 · 2023-05-31T12:38:39Z

@DHaussermann Gentle reminder for review

raghavaggarwal2308 · 2023-06-06T09:25:24Z

@DHaussermann Gentle reminder for review

raghavaggarwal2308 · 2023-06-21T14:47:44Z

@DHaussermann Gentle reminder for review

raghavaggarwal2308 · 2023-07-11T08:28:52Z

@DHaussermann Gentle reminder for review

raghavaggarwal2308 · 2023-08-17T10:05:51Z

@DHaussermann Gentle reminder for review

mattermost-build · 2023-10-27T01:03:26Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

AayushChaudhary0001

Tested and approved. working fine for both pull requests links and issue links, LGTM.

…ab into link_tooltip

mickmister · 2023-12-15T18:16:23Z

The RC for this release is running on community, though I'm not seeing the link tooltip working for our self-hosted version of GitLab. @avas27JTG @raghavaggarwal2308 Any ideas why this might be the case? There is no HTTP request being made by the frontend to fetch the tooltip information. No errors in the browser console either.

ayusht2810 · 2023-12-18T09:51:29Z

@mickmister The release candidate v1.8.0-rc1 was missing the link_tooltip component therefore the tooltip was not visible. I have synced the bump version PR with the latest master, and the tooltip is working fine now.

shivamjosh and others added 3 commits June 1, 2022 19:29

MI-1845: Added tooltip for pull request and issue links

7451617

MI-1845: Done review fixes

915f7e8

Merge pull request #5 from Brightscout/MI-1845

1805313

MI-1845: Added tooltip for pull request and issue links

shivamjosh requested a review from mickmister as a code owner June 6, 2022 12:05

shivamjosh added 2 commits June 6, 2022 18:15

Added the verbose flag to the npm install command in Makefile to fix …

5e8f935

…failing CI

Merge branch 'link_tooltip' of github.com:Brightscout/mattermost-plug…

65f1b7c

…in-gitlab into link_tooltip

Fixed lint errors

acd24e3

mickmister requested review from DHaussermann and levb June 12, 2022 20:44

mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 12, 2022

mickmister requested a review from pvev June 12, 2022 20:47

pvev reviewed Jun 15, 2022

View reviewed changes

webapp/src/components/link_tooltip/link_tooltip.jsx Outdated Show resolved Hide resolved

pvev reviewed Jun 15, 2022

View reviewed changes

webapp/src/components/link_tooltip/link_tooltip.jsx Outdated Show resolved Hide resolved

pvev reviewed Jun 15, 2022

View reviewed changes

webapp/src/components/link_tooltip/link_tooltip.jsx Outdated Show resolved Hide resolved

shivamjosh added 7 commits June 17, 2022 12:22

Added regex for url valiation and constants for link types and states

b339c6f

Fixed linting errors

13f0747

Removed unnecessary escape character

cfe9658

Minor code improvement

94e59dd

Fixed CI lint error

73389ab

Added babel config for optional chaining

072a9e2

Added missing trailing comma

80393bf

shivamjosh requested a review from pvev June 22, 2022 12:45

pvev approved these changes Jun 25, 2022

View reviewed changes

shivamjosh and others added 2 commits June 28, 2022 12:55

Fixed typo

ec0ba0f

Merge branch 'link_tooltip' of github.com:Brightscout/mattermost-plug…

7ffa95f

…in-gitlab into link_tooltip

mattermod added the Lifecycle/1:stale label Jul 12, 2022

trilopin added this to the v1.8.0 milestone Apr 19, 2023

mattermost-build added the Lifecycle/1:stale label Apr 30, 2023

Merge branch 'master' of github.com:mattermost/mattermost-plugin-gitl…

8777bf3

…ab into link_tooltip

hanzei requested review from AayushChaudhary0001 and removed request for DHaussermann October 16, 2023 20:19

hanzei removed the Lifecycle/1:stale label Oct 16, 2023

mattermost-build added the Lifecycle/1:stale label Oct 27, 2023

AayushChaudhary0001 approved these changes Nov 20, 2023

View reviewed changes

Merge branch 'master' of github.com:mattermost/mattermost-plugin-gitl…

424eec9

…ab into link_tooltip

avas27JTG merged commit b5184fa into mattermost:master Nov 29, 2023

avas27JTG deleted the link_tooltip branch November 29, 2023 09:17

avas27JTG modified the milestones: v1.9.0, v1.8.0 Nov 29, 2023

avas27JTG mentioned this pull request Nov 29, 2023

Bump version to 1.8.0. #417

Merged

hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale 3: QA Review Requires review by a QA tester labels Dec 18, 2023

avas27JTG modified the milestones: v1.8.0, v1.9.0 Dec 19, 2023

mickmister mentioned this pull request Jan 25, 2024

Release 1.9.0 #448

Closed

Conversation

shivamjosh commented Jun 6, 2022 • edited by hanzei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Uh oh!

mattermod commented Jun 6, 2022

Uh oh!

codecov bot commented Jun 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

pvev Jun 15, 2022

Choose a reason for hiding this comment

Uh oh!

shivamjosh Jun 17, 2022

Choose a reason for hiding this comment

Uh oh!

mickmister Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

raghavaggarwal2308 Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pvev left a comment

Choose a reason for hiding this comment

Uh oh!

mattermost-build commented Apr 30, 2023

Uh oh!

raghavaggarwal2308 commented Apr 30, 2023

Uh oh!

raghavaggarwal2308 commented May 31, 2023

Uh oh!

raghavaggarwal2308 commented Jun 6, 2023

Uh oh!

raghavaggarwal2308 commented Jun 21, 2023

Uh oh!

raghavaggarwal2308 commented Jul 11, 2023

Uh oh!

raghavaggarwal2308 commented Aug 17, 2023

Uh oh!

mattermost-build commented Oct 27, 2023

Uh oh!

AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

Uh oh!

mickmister commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ayusht2810 commented Dec 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

shivamjosh commented Jun 6, 2022 •

edited by hanzei

Loading

codecov bot commented Jun 6, 2022 •

edited

Loading

raghavaggarwal2308 Aug 26, 2022 •

edited

Loading

mickmister commented Dec 15, 2023 •

edited

Loading