Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-813: Fixed the issue of wrong name shown in subscription when PR is moved from draft to ready for review #814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kshitij-Katiyar
Copy link
Contributor

Description

Fixed the issue of the wrong name shown in the subscription when PR is moved from draft to ready for review

Ticket link

Fixes #813

What to test

  • Create a subscription for a repo
  • Create a PR with user B and mark it as draft
  • Mark the PR as ready for review from user A

Expected

#new-pull-request by B

Actual

#new-pull-request by A

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 27, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Aug 28, 2024
@AayushChaudhary0001
Copy link

@Kshitij-Katiyar I was testing this PR and this functionality is not working, can you please take a look at it as discussed?
Adding screenshots for reference:-
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing invalid name when a draft PR is marked as ready
4 participants