refactor: pluginctl v0.1.5-0.20250814142442-19c417d53e1d#186
Open
refactor: pluginctl v0.1.5-0.20250814142442-19c417d53e1d#186
Conversation
Contributor
Author
fmartingr
force-pushed
the
refactor/pluginctl
branch
from
7fa9cfa to
7e22e69
Compare
hanzei
requested changes
Sep 16, 2025
Contributor
hanzei
left a comment
hanzei
left a comment
There was a problem hiding this comment.
I'm a bit hesitant to migrate this repo over until the discussion about pluginctl is resolved. I'm blocking until then.
Contributor
There was a problem hiding this comment.
This goes back to the changes in mattermost/mattermost-plugin-starter-template#192. With that PR, we auto-generate the manifest every time we build the bundle, because the version field now depends on the git history. The demo plugin never adopted the new pattern.
The changes in this PR are fine.
| "homepage_url": "https://github.com/mattermost/mattermost-plugin-demo", | ||
| "support_url": "https://github.com/mattermost/mattermost-plugin-demo/issues", | ||
| "icon_path": "assets/icon.svg", | ||
| "version": "0.10.0", |
Contributor
There was a problem hiding this comment.
I think we should remove that field now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example PR on how to migrate a plugin to
pluginctl.webapp.config.jsandbabel.config.jsto the manifestprops.pluginctl.ignore_assets.build/setup.mk,build/manifest&build/pluginctl.pluginctl updateassets.Migration guide: mattermost/pluginctl#2
Closes: #180