Added Oauth setup and connect disconnect command#126
Merged
Kshitij-Katiyar merged 31 commits intooauth_epicfrom Mar 13, 2025
Merged
Added Oauth setup and connect disconnect command#126Kshitij-Katiyar merged 31 commits intooauth_epicfrom
Kshitij-Katiyar merged 31 commits intooauth_epicfrom
Conversation
…-confluence-fork into oauth_setup
fmartingr
requested changes
Feb 20, 2025
Contributor
fmartingr
left a comment
fmartingr
left a comment
There was a problem hiding this comment.
Left some comments around. Genrally I don't like the defer usage for errors since not only make code harder to follow, there are a lot of places where is not doing anything since the variable being returned is not the same one being modified in the defer call.
The logic is not being split in different domains, which will make it harder to iterate on and test since we have a lot of functions tied to the main Plugin object. I don't want to overstep here a lot since I don't know what are the rules of the game here so will leave that to Doug to comment on.
…st-plugin-confluence into oauth_setup
…st-plugin-confluence into oauth_setup
Contributor
Author
|
@fmartingr Fixed the review comments, please rereview |
fmartingr
requested review from
BenCookie95
and removed request for
fmartingr
fmartingr
requested review from
davidkrauser
and removed request for
BenCookie95 and
wiggin77
* Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * refactored code and added constants * fixed lint * review fixes and removed unused codes * fixed lint * moved types out of functions * review fixes * review fixes * fixed lint * review fixes * removed unused code
raghavaggarwal2308
suggested changes
Mar 11, 2025
raghavaggarwal2308
approved these changes
Mar 12, 2025
…st-plugin-confluence into oauth_setup
fmartingr
approved these changes
Mar 13, 2025
|
@davidkrauser Is there anything left from your end on this PR? |
davidkrauser
approved these changes
Mar 13, 2025
davidkrauser
left a comment
davidkrauser
left a comment
There was a problem hiding this comment.
LGTM - thank you for making changes 👍
…st-plugin-confluence into oauth_setup
Kshitij-Katiyar
added a commit
that referenced
this pull request
Mar 20, 2025
… than 9 (#134) * Refactored the code and added flow manager for Oauth setup (#125) * refactored the code and added flow manager * removed unused code * fixed lint * removed unwanted code and added mutliple status code handling * fixed lint * fixed step title * removed extra lines in flow instructions * review fixes * fixed lint * review fixes * removed unused code * fixed go mod enteries * Added Oauth setup and connect disconnect command (#126) * refactored the code and added flow manager * removed unused code * fixed lint * added oauth setup and connect disconnect command * removed unrelated changes from package lock * fixed lint * fixed missing go mod entry * removed unwanted code and added mutliple status code handling * fixed lint * fixed step title * removed unwanted variables * removed extra lines in flow instructions * updated flow messages * review fixes * fixed callJSONwithURL call * review fixes * fixed lint * fixed lint * Added support for notification with server version greater than 9 (#127) * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * refactored code and added constants * fixed lint * review fixes and removed unused codes * fixed lint * moved types out of functions * review fixes * review fixes * fixed lint * review fixes * removed unused code * review fixes * review fixes * removed unused code * fixed go mod enteries * removed external css sheet * review fixes * Added support for generic notification when user is not connected (#128) * refactored the code and added flow manager * removed unused code * fixed lint * added oauth setup and connect disconnect command * removed unrelated changes from package lock * fixed lint * fixed missing go mod entry * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * removed unwanted code and added mutliple status code handling * fixed lint * fixed step title * removed unwanted variables * refactored code and added constants * fixed lint * added support for generic notification when user not connected * fixed lint * removed extra lines in flow instructions * updated flow messages * review fixes and removed unused codes * fixed lint * moved types out of functions * add more log information * fixed log info * review fixes * review fixes * review fixes * fixed callJSONwithURL call * review fixes * fixed lint * fixed lint * fixed lint * Added support for notification with server version greater than 9 (#127) * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * refactored code and added constants * fixed lint * review fixes and removed unused codes * fixed lint * moved types out of functions * review fixes * review fixes * fixed lint * review fixes * removed unused code * fixed missing var * review fixes * review fixes * review fixes * removed unused code * fixed go mod enteries * removed external css sheet * review fixes * Added support for using admin API token for webhook notifications (#129) * refactored the code and added flow manager * removed unused code * fixed lint * added oauth setup and connect disconnect command * removed unrelated changes from package lock * fixed lint * fixed missing go mod entry * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * removed unwanted code and added mutliple status code handling * fixed lint * fixed step title * removed unwanted variables * refactored code and added constants * fixed lint * added support for generic notification when user not connected * fixed lint * added support for admin api token * removed unused code * fixed lint * fixed import issues * removed extra lines in flow instructions * saved server version in plugin config * updated flow messages * review fixes and removed unused codes * fixed lint * moved types out of functions * add more log information * fixed log info * removed unwanted code and improved logs * fixed type in config descriptions * updated config descriptions * review fixes * review fixes * review fixes * fixed callJSONwithURL call * review fixes * fixed lint * fixed lint * fixed lint * removed unused variables * Added support for notification with server version greater than 9 (#127) * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * refactored code and added constants * fixed lint * review fixes and removed unused codes * fixed lint * moved types out of functions * review fixes * review fixes * fixed lint * review fixes * removed unused code * review fixes * fixed missing var * added comment to notification logic * review fixes * review fixes * review fixes * fixed lint * review fixes * removed unused code * fixed go mod enteries * replaced marshalling with byte conversion * removed external css sheet * review fixes * Update server/confluence_cloud.go log info Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com> * removed unused vars --------- Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com> * Removed encryption for admin API token (#133) * refactored the code and added flow manager * removed unused code * fixed lint * added oauth setup and connect disconnect command * removed unrelated changes from package lock * fixed lint * fixed missing go mod entry * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * removed unwanted code and added mutliple status code handling * fixed lint * fixed step title * removed unwanted variables * refactored code and added constants * fixed lint * added support for generic notification when user not connected * fixed lint * added support for admin api token * removed unused code * fixed lint * fixed import issues * removed extra lines in flow instructions * saved server version in plugin config * updated flow messages * review fixes and removed unused codes * fixed lint * moved types out of functions * add more log information * fixed log info * removed unwanted code and improved logs * fixed type in config descriptions * updated config descriptions * review fixes * review fixes * review fixes * fixed callJSONwithURL call * review fixes * fixed lint * fixed lint * fixed lint * removed unused variables * Added support for notification with server version greater than 9 (#127) * Added support for notification with server version > 9 * fixed disconnect error * fixed lint issues * refactored code and added constants * fixed lint * review fixes and removed unused codes * fixed lint * moved types out of functions * review fixes * review fixes * fixed lint * review fixes * removed unused code * review fixes * fixed missing var * added comment to notification logic * review fixes * review fixes * review fixes * fixed lint * review fixes * removed unused code * fixed go mod enteries * replaced marshalling with byte conversion * removed external css sheet * review fixes * Update server/confluence_cloud.go log info Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com> * removed encryption for admin api token * improved help text for encryption key * removed unused var in plugin struct --------- Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com> * fix issues reported by QA * Fixed lint and testcases * fixed import orders * fixed issue of system admin required for API call * removed unused vars * updated the system admin check for webapp based slash command * updated message for system admin commands * updated msg for non admin user running confluence commands for server version < 9 --------- Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Oauth setup and connect disconnect command
Screenshots