Removed react-native-router-flux and added custom navigation logic - #101
Closed
hmhealey wants to merge 19 commits into
Closed
Removed react-native-router-flux and added custom navigation logic#101hmhealey wants to merge 19 commits into
hmhealey wants to merge 19 commits into
Conversation
Contributor
|
OK lets merge my PR first so this one get a lot smaller (I think) and after that I'll review |
4 tasks
yasserfaraazkhan
added a commit
that referenced
this pull request
Aug 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
yasserfaraazkhan
added a commit
that referenced
this pull request
Aug 17, 2026
Staging will run #101 at this tip; keep mobile action pin in lockstep. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic way this works now is that we have the navigation section of the redux store that's controlled with standard actions and a reducer. Right now, it only uses simple actions that push, pop, and reset the stack, but it has support for anything that NavigationExperimental can handle.
Since this is based off the store changes, here are the changes specific to this PR: b1d9c63...e4f7a63
Overview of directory changes:
-src/scenes - This used to be named src/routes, but I think it was a good idea to separate the definition of a route (which usually involves how you get there) from a scene (which is the actual contents of the route) and to make it more clear that this navigation isn't using a router with a path like we had before.