Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-55614] Remove trailing comma from lists #46

Merged
merged 1 commit into from
Nov 20, 2023
Merged

[MM-55614] Remove trailing comma from lists #46

merged 1 commit into from
Nov 20, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 20, 2023 •
edited
Loading

Summary

The plain formatter no longer appends a trailing comma to slice and map fields.

Ticket Link

https://mattermost.atlassian.net/browse/MM-55614

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 20, 2023
@github-actions GitHub Actions
Copy link

Unit Test Results

93 tests  +12   93 ✔️ +12   23s ⏱️ ±0s
10 suites ±  0     0 💤 ±  0 
  1 files   ±  0     0 ❌ ±  0 

Results for commit ec3f5a7. ± Comparison against base commit a9cb1dc.

@hanzei hanzei marked this pull request as ready for review November 20, 2023 14:47
@hanzei hanzei requested a review from wiggin77 November 20, 2023 14:47
wiggin77
wiggin77 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 20, 2023
@hanzei hanzei merged commit 1d340b9 into master Nov 20, 2023
2 checks passed
@hanzei hanzei deleted the MM-55614_list-trailing-comma branch November 20, 2023 17:13
@hanzei hanzei mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzei @wiggin77