Simplify Field API using generics #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the different |
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
reviewed
Nov 10, 2023
wiggin77
approved these changes
Nov 10, 2023
Co-authored-by: Doug Lauder <[email protected]>
Co-authored-by: Doug Lauder <[email protected]>
hanzei
added
4: Reviews Complete
|
Thanks for the review @wiggin77 👍 Can we merge the PR? |
hanzei
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internally,
logrthreads typed that allow Type conversions to "higher" types the same. E.g. anint32get converted into anint64anyway.By adding generics field functions for each "class" of types, the API becomes simpler to read and use. No type conversions are needed on the callers' side.
All field functions also allow the usage of type definition without type conversions from the caller.
To summarize:
IntreplacesInt32andInt64UintreplacesUint32andUint64FloatreplacesFloat32andFloat64I thought about consolidating the fields even further, but that adds problems with
gojay.Based on top of #43
Ticket Link
None