Cherry-pick of #3945 to release-6.2 - #3948
Merged
yasserfaraazkhan merged 2 commits intoAug 14, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Replace nested ternaries and a negated condition in the release-6.2 backport of #3945 so ci lint can pass. Behavior is unchanged. Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>
yasserfaraazkhan
marked this pull request as ready for review
August 14, 2026 09:59
|
❌ E2E Test Setup Failed Failed to create E2E test instances: failed to create installation: failed with status code 409 |
amyblais
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #3945 on release-6.2.
Restores per-OS GitHub commit statuses (
e2e/linux,e2e/macos,e2e/windows) for CMT, alongside the existinge2e/compatibility-matrix-testingumbrella. PR/master E2E already posted per-OS checks on this branch; those now use canonicallinux|macos|windowsnames.Summary
instance_detailsplatforms tolinux|macos|windows(and pinmacos-latest→macos-26) soe2e/<os>statuses stay consistent.e2e/linux|macos|windowson CMT start, then flip them from CMT matrix job conclusions (this branch has no TSIO reporter).e2e/compatibility-matrix-testing.no-nested-ternary/no-negated-conditionpass (cmtOsCommitStatus,playwrightProjectForOs).Ticket Link
Cherry-pick of #3945
Checklist
npm run lint:jsfor proper code formattingE2E/RunDevice Information
This PR was tested on: unit tests via
node --test e2e/utils/github-actions.test.js(10 passed);npx eslint e2e/utils/github-actions.js e2e/utils/github-actions.test.js --quietcleanRelease Note
Backport notes
Automated cherry-pick conflicted because
release-6.2does not have TSIO reporting (tsio-report-status.js) or channel notify (cmt-channel-notify.js).What this PR includes:
linux-11.9.0, …)What this PR does not include:
e2e/<os>-policystatus rename (policy-test/<os>remains)media_preview.test.ts— that spec does not exist onrelease-6.2Merge gate: wait for
ci(build-linux,build-mac-no-dmg,build-win-no-installer,report-test-results) on HEAD393ae8bb. PlaywrightE2E/Runis not required for this CI-only change; latestrelease-6.2CMT is already green. Needs a review (currently none).