ci(cmt): backport macos Bash 3.2 fix + drop legacy runner remap - #3934
Merged
Conversation
…release-6.3
CMT on v6.3.0-rc.3 failed every macos-26 leg in e2e/set-required-variables
with `bad substitution` from `${RUNNER_OS^^}` (Bash 3.2). Port the tr-based
uppercase from #3902 and the Matterwick v0.4.16 matrix pass-through from #3920
without the rest of those PRs' master-only changes.
Co-authored-by: Cursor <cursoragent@cursor.com>
mm-cloud-bot
added
kind/chore
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
amyblais
approved these changes
Aug 5, 2026
amyblais
added
the
4: Reviews Complete
yasserfaraazkhan
added
CherryPick/Candidate
6 tasks
amyblais
pushed a commit
that referenced
this pull request
Aug 12, 2026
#3944) release-6.2 CMT Provisioner only had workflow_dispatch (no RC tag push), so v6.2.3-rc.* never auto-triggered Matterwick. Port the RC-tag trigger from #3846, the Bash 3.2 Zephyr env fix needed for macos-26 CMT legs, and update matrix schema comments for Matterwick ≥ v0.4.16 (#3920). Automated cherry-picks conflicted; same approach as #3934 on release-6.3. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual backport to
release-6.3after automated/cherry-pickof #3920 conflicted.CMT on
v6.3.0-rc.3(run 30788534920) put every macOS leg onmacos-26(Matterwickv0.4.16+is fine) but all five failed immediately ine2e/set-required-variables:macOS runners ship Bash 3.2, which rejects
${var^^}.What this PR includes
RUNNER_OS_UPPER=$(… | tr …)instead of${RUNNER_OS^^}cmt/normalize-matrix-runners; pass Matterwick matrix through; update schema comments toubuntu-latest/macos-26v0.4.16(already sends those runners)What this PR deliberately does not cherry-pick
Full #3902 (release-channel notify, TSIO pin bumps, BUILD_SUFFIX renames, e2e helper/test changes) — not needed to fix this CMT failure and would widen conflict/risk on
release-6.3.Test plan
release-6.3release-6.3(or re-cut / re-dispatch CMT for the 6.3 RC line)e2e/set-required-variables(nobad substitution)macos-26/ubuntu-latest/windows-2022Made with Cursor