chore(e2e): fix tsio reporting link and Do not post master report to release report channel - #3917
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesThe change separates Mattermost routing for CMT/RC, desktop master, and desktop PR reports, makes named routes fail closed when dedicated webhooks are missing, and enables staging TSIO reporting in E2E workflows. Mattermost and TSIO workflow updates
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/utils/cmt-channel-notify.js`:
- Around line 101-105: Update the webhook selection logic for cmt-desktop,
desktop-master, and desktop-pr so each named report returns only its dedicated
environment variable, or an empty value when that secret is missing; remove the
MATTERMOST_WEBHOOK_URL fallback for these branches. Add tests covering each
dedicated secret being absent while the shared secret is populated, asserting no
shared webhook is returned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 43818a95-949b-4b78-b0d1-ef30772cf971
📒 Files selected for processing (5)
.github/workflows/compatibility-matrix-testing.yml.github/workflows/e2e-functional.ymle2e/utils/cmt-channel-notify.jse2e/utils/cmt-channel-notify.test.jse2e/utils/tsio-report-status.js
💤 Files with no reviewable changes (1)
- .github/workflows/compatibility-matrix-testing.yml
Named report groups (cmt/master/pr) use only their dedicated webhook secret so a missing secret never posts to the shared fallback channel. Co-authored-by: Cursor <cursoragent@cursor.com>
…OOK_URL Master E2E channel notify uses the dedicated master-health webhook; PR keeps MM_DESKTOP_E2E_WEBHOOK_URL and CMT keeps the release webhook. Co-authored-by: Cursor <cursoragent@cursor.com>
Canonicalize run_type MAIN→MASTER when building the TSIO identity name, and treat desktop-main like desktop-master for webhook/notify selection. Co-authored-by: Cursor <cursoragent@cursor.com>
Desktop master pushes are Matterwick MASTER → desktop-master only. Mobile keeps MAIN/MASTER→mobile-main; that does not apply to desktop. Co-authored-by: Cursor <cursoragent@cursor.com>
Pin report-upload to main@b5580f4 and enable useStaging so desktop E2E hits staging-test-io after the staging deploy of the Maestro/Detox ingest fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Skip the flaky settings category click that tears down the Linux WebContentsView mid-action; open/close via cancelModal like focus tests, and settle briefly after tiling before interacting. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Pin report-upload to release-0.12.0 and drop use-staging after #81 validation. Co-authored-by: Cursor <cursoragent@cursor.com>
…ures Restore settings chrome exercise to click #settingCategoryButton-general and drop the Linux settle sleeps from 6849e17/d69a9e24. Co-authored-by: Cursor <cursoragent@cursor.com>
fix tsio reporting link and Do not post master report to release report channel
Change Impact: 🟡 Medium
Regression Risk: Changes update shared Mattermost webhook routing/skip behavior across E2E/TSIO/CMT/master reporting, including a fail-closed path when dedicated webhook secrets are missing. This is limited to notifications/report publishing (not core product logic), but misrouting could affect multiple workflows and external channel updates. Unit tests were updated to match the new routing rules.
QA Recommendation: Skip full manual QA; spot-check at least one e2e run per report group (
desktop-pr,desktop-master,cmt-desktop) to verify the correct webhook/channel receives (or omits) notifications when relevant webhook secrets are set vs unset.Generated by CodeRabbitAI