Skip to content

chore(e2e): fix tsio reporting link and Do not post master report to release report channel - #3917

Merged
yasserfaraazkhan merged 10 commits into
masterfrom
update_report_channel_webhook_variable
Jul 22, 2026
Merged

chore(e2e): fix tsio reporting link and Do not post master report to release report channel#3917
yasserfaraazkhan merged 10 commits into
masterfrom
update_report_channel_webhook_variable

Conversation

@yasserfaraazkhan

@yasserfaraazkhan yasserfaraazkhan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

fix tsio reporting link and Do not post master report to release report channel

NONE

Change Impact: 🟡 Medium

Regression Risk: Changes update shared Mattermost webhook routing/skip behavior across E2E/TSIO/CMT/master reporting, including a fail-closed path when dedicated webhook secrets are missing. This is limited to notifications/report publishing (not core product logic), but misrouting could affect multiple workflows and external channel updates. Unit tests were updated to match the new routing rules.
QA Recommendation: Skip full manual QA; spot-check at least one e2e run per report group (desktop-pr, desktop-master, cmt-desktop) to verify the correct webhook/channel receives (or omits) notifications when relevant webhook secrets are set vs unset.
Generated by CodeRabbitAI

@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Changes

The change separates Mattermost routing for CMT/RC, desktop master, and desktop PR reports, makes named routes fail closed when dedicated webhooks are missing, and enables staging TSIO reporting in E2E workflows.

Mattermost and TSIO workflow updates

Layer / File(s) Summary
Fail-closed webhook routing and tests
e2e/utils/cmt-channel-notify.js, e2e/utils/cmt-channel-notify.test.js
Named report groups use dedicated webhooks and return an empty URL when those variables are missing; unknown names retain shared-webhook fallback.
Workflow webhook and staging wiring
.github/workflows/*.yml
E2E and compatibility-matrix workflows use separated webhook variables and staging-enabled TSIO reporting and upload actions.
TSIO routing documentation
e2e/utils/tsio-report-status.js
Inline documentation lists separate webhook mappings for CMT/RC, desktop master, and desktop PR reports.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested labels: kind/chore, github_actions

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main changes: fixing TSIO reporting and preventing master reports from going to the release report channel.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_report_channel_webhook_variable

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2e/utils/cmt-channel-notify.js`:
- Around line 101-105: Update the webhook selection logic for cmt-desktop,
desktop-master, and desktop-pr so each named report returns only its dedicated
environment variable, or an empty value when that secret is missing; remove the
MATTERMOST_WEBHOOK_URL fallback for these branches. Add tests covering each
dedicated secret being absent while the shared secret is populated, asserting no
shared webhook is returned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 43818a95-949b-4b78-b0d1-ef30772cf971

📥 Commits

Reviewing files that changed from the base of the PR and between 687f93f and d803d14.

📒 Files selected for processing (5)
  • .github/workflows/compatibility-matrix-testing.yml
  • .github/workflows/e2e-functional.yml
  • e2e/utils/cmt-channel-notify.js
  • e2e/utils/cmt-channel-notify.test.js
  • e2e/utils/tsio-report-status.js
💤 Files with no reviewable changes (1)
  • .github/workflows/compatibility-matrix-testing.yml

Comment thread e2e/utils/cmt-channel-notify.js Outdated
@github-actions github-actions Bot removed the E2E/Run Run Desktop E2E Tests label Jul 21, 2026
Named report groups (cmt/master/pr) use only their dedicated webhook
secret so a missing secret never posts to the shared fallback channel.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jul 21, 2026
…OOK_URL

Master E2E channel notify uses the dedicated master-health webhook; PR
keeps MM_DESKTOP_E2E_WEBHOOK_URL and CMT keeps the release webhook.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 21, 2026
Canonicalize run_type MAIN→MASTER when building the TSIO identity name,
and treat desktop-main like desktop-master for webhook/notify selection.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jul 21, 2026
Desktop master pushes are Matterwick MASTER → desktop-master only.
Mobile keeps MAIN/MASTER→mobile-main; that does not apply to desktop.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 21, 2026
Pin report-upload to main@b5580f4 and enable useStaging so desktop E2E
hits staging-test-io after the staging deploy of the Maestro/Detox ingest fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 21, 2026
Skip the flaky settings category click that tears down the Linux
WebContentsView mid-action; open/close via cancelModal like focus tests,
and settle briefly after tiling before interacting.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jul 22, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 22, 2026
Pin report-upload to release-0.12.0 and drop use-staging after #81 validation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 22, 2026
…ures

Restore settings chrome exercise to click #settingCategoryButton-general
and drop the Linux settle sleeps from 6849e17/d69a9e24.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added E2E/Run Run Desktop E2E Tests and removed E2E/Run Run Desktop E2E Tests labels Jul 22, 2026
@yasserfaraazkhan
yasserfaraazkhan merged commit 86ed37e into master Jul 22, 2026
35 checks passed
@yasserfaraazkhan
yasserfaraazkhan deleted the update_report_channel_webhook_variable branch July 22, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants