fix(cmt): trigger on RC tag cut instead of release branch push - #3877
Merged
yasserfaraazkhan merged 3 commits intoJun 30, 2026
Conversation
Shorten the header comment, rename the job to trigger-matterwick for consistency with the mobile repo, and collapse the multi-line echo to one line. No functional change — the workflow still just emits a workflow_run event that matterwick reacts to. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Matterwick keys CMT cleanup on the dispatched test workflow run id, matching the mobile repo's behavior. The "matched by commit SHA" note was stale. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
release-v* never matched since real branches are release-X.Y (no v prefix). Align with PR #3846: fire on v*-rc* tags (e.g. v6.2.0-rc.1) so CMT runs on each RC cut, not on every release-branch push. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CMT provisioner workflow trigger changes from ChangesCMT Workflow Trigger Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
saturninoabril
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Thanks @yasserfaraazkhan! (Failed E2E tests to address separately)
yasserfaraazkhan
deleted the
fix/cmt-direct-dispatch-and-cleanup-endpoint
branch
June 30, 2026 04:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The CMT Provisioner was set to fire on every push to
release-v*branches, but desktop release branches are namedrelease-X.Y(novprefix) so the trigger never matched in practice. This PR fixes that.What changed:
v*-rc*, e.g.v6.2.0-rc.1) instead of release branch pushes. This matches how the release process actually works. An RC tag is cut when QA is ready to test, not on every branch push.Change Impact: 🟢 Low
Regression Risk: Isolated GitHub Actions workflow changes with a narrow blast radius. The main risk is missed or unexpected workflow triggering on RC tags, but runtime behavior of the underlying job logic is largely unchanged.
QA Recommendation: Minimal manual QA is sufficient—verify the workflow triggers on a
v*-rc*tag and still runs via manual dispatch.