Skip to content

fix(cmt): trigger on RC tag cut instead of release branch push - #3877

Merged
yasserfaraazkhan merged 3 commits into
masterfrom
fix/cmt-direct-dispatch-and-cleanup-endpoint
Jun 30, 2026
Merged

fix(cmt): trigger on RC tag cut instead of release branch push#3877
yasserfaraazkhan merged 3 commits into
masterfrom
fix/cmt-direct-dispatch-and-cleanup-endpoint

Conversation

@yasserfaraazkhan

@yasserfaraazkhan yasserfaraazkhan commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary:

The CMT Provisioner was set to fire on every push to release-v* branches, but desktop release branches are named release-X.Y (no v prefix) so the trigger never matched in practice. This PR fixes that.

What changed:

  • Trigger corrected: CMT Provisioner now fires on RC tag cuts (v*-rc*, e.g. v6.2.0-rc.1) instead of release branch pushes. This matches how the release process actually works. An RC tag is cut when QA is ready to test, not on every branch push.
NONE

Change Impact: 🟢 Low

Regression Risk: Isolated GitHub Actions workflow changes with a narrow blast radius. The main risk is missed or unexpected workflow triggering on RC tags, but runtime behavior of the underlying job logic is largely unchanged.

QA Recommendation: Minimal manual QA is sufficient—verify the workflow triggers on a v*-rc* tag and still runs via manual dispatch.

yasserfaraazkhan and others added 3 commits June 30, 2026 06:10
Shorten the header comment, rename the job to trigger-matterwick for
consistency with the mobile repo, and collapse the multi-line echo to
one line. No functional change — the workflow still just emits a
workflow_run event that matterwick reacts to.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Matterwick keys CMT cleanup on the dispatched test workflow run id, matching
the mobile repo's behavior. The "matched by commit SHA" note was stale.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
release-v* never matched since real branches are release-X.Y (no v prefix).
Align with PR #3846: fire on v*-rc* tags (e.g. v6.2.0-rc.1) so CMT runs
on each RC cut, not on every release-branch push.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none labels Jun 30, 2026
@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 94f3eba4-7009-473c-bbfd-80df72952354

📥 Commits

Reviewing files that changed from the base of the PR and between 098f4d0 and d9fd1b1.

📒 Files selected for processing (2)
  • .github/workflows/cmt-provisioner.yml
  • .github/workflows/compatibility-matrix-testing.yml

📝 Walkthrough

Walkthrough

The CMT provisioner workflow trigger changes from release-v* branch pushes to v*-rc* tag pushes. The job is renamed from signal to trigger-matterwick and the run command is simplified. A comment in the compatibility matrix testing workflow is updated to reference run ID instead of commit SHA.

Changes

CMT Workflow Trigger Update

Layer / File(s) Summary
Trigger and job updates
.github/workflows/cmt-provisioner.yml, .github/workflows/compatibility-matrix-testing.yml
Provisioner trigger switched to RC tag pushes (v*-rc*), job renamed to trigger-matterwick, run command simplified to single echo; cancellation matching comment updated to reference workflow run ID.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: switching the CMT trigger from release branch pushes to RC tag cuts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cmt-direct-dispatch-and-cleanup-endpoint

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot removed the E2E/Run Run Desktop E2E Tests label Jun 30, 2026

@saturninoabril saturninoabril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yasserfaraazkhan! (Failed E2E tests to address separately)

@saturninoabril saturninoabril added the 4: Reviews Complete All reviewers have approved the pull request label Jun 30, 2026
@yasserfaraazkhan
yasserfaraazkhan merged commit c436e1f into master Jun 30, 2026
49 of 51 checks passed
@yasserfaraazkhan
yasserfaraazkhan deleted the fix/cmt-direct-dispatch-and-cleanup-endpoint branch June 30, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request kind/bug Categorizes issue or PR as related to a bug. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants