Skip to content

E2E: Menu bar specs - #3863

Merged
yasserfaraazkhan merged 2 commits into
e2e/08-notifications-focus-callsfrom
e2e/09-menu-bar
Jul 1, 2026
Merged

E2E: Menu bar specs#3863
yasserfaraazkhan merged 2 commits into
e2e/08-notifications-focus-callsfrom
e2e/09-menu-bar

Conversation

@yasserfaraazkhan

Copy link
Copy Markdown
Contributor

Summary

Stacked PR 9/10 — menu bar specs + permissions IPC.

Test plan

  • e2e/specs/menu_bar/

@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2c564b28-89c0-43db-ba10-d8a2278f6141

📥 Commits

Reviewing files that changed from the base of the PR and between 08129c4 and be070f5.

📒 Files selected for processing (11)
  • e2e/specs/menu_bar/clear_all_data.test.ts
  • e2e/specs/menu_bar/devtools_current_server.test.ts
  • e2e/specs/menu_bar/diagnostics.test.ts
  • e2e/specs/menu_bar/edit_menu.test.ts
  • e2e/specs/menu_bar/file_menu.test.ts
  • e2e/specs/menu_bar/full_screen.test.ts
  • e2e/specs/menu_bar/help_menu.test.ts
  • e2e/specs/menu_bar/menu.test.ts
  • e2e/specs/menu_bar/view_menu.test.ts
  • e2e/specs/menu_bar/window_menu.test.ts
  • e2e/specs/permissions/permissions_ipc.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch e2e/09-menu-bar

Comment @coderabbitai help to get the list of available commands.

@yasserfaraazkhan yasserfaraazkhan changed the title E2E: Menu bar specs (9/10) E2E: Menu bar specs Jun 19, 2026
Base automatically changed from e2e/02-main-hooks to e2e/01-harness-ci June 19, 2026 11:21
Base automatically changed from e2e/01-harness-ci to master June 30, 2026 23:13
Resolve harness/hook conflicts by keeping merged #3855 changes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the E2E/Run Run Desktop E2E Tests label Jun 30, 2026
@mm-cloud-bot

Copy link
Copy Markdown

❌ E2E Test Setup Failed

Failed to create E2E test instances: failed to create installation: failed with status code 409

@yasserfaraazkhan

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yasserfaraazkhan yasserfaraazkhan added E2E/Reset-Servers Destroy E2E server for a fresh Run. Add E2E/Run label to kick off an e2e run. and removed E2E/Run Run Desktop E2E Tests E2E/Reset-Servers Destroy E2E server for a fresh Run. Add E2E/Run label to kick off an e2e run. labels Jul 1, 2026
@yasserfaraazkhan
yasserfaraazkhan changed the base branch from master to e2e/10-tray-settings-deeplink July 1, 2026 00:24
@yasserfaraazkhan
yasserfaraazkhan changed the base branch from e2e/10-tray-settings-deeplink to e2e/08-notifications-focus-calls July 1, 2026 00:24
@yasserfaraazkhan
yasserfaraazkhan merged commit 081a3b5 into e2e/08-notifications-focus-calls Jul 1, 2026
28 of 29 checks passed
@yasserfaraazkhan
yasserfaraazkhan deleted the e2e/09-menu-bar branch July 1, 2026 00:25
yasserfaraazkhan added a commit that referenced this pull request Jul 1, 2026
PR #3863 imported waitForMattermostShell without adding the helper file,
which blocked Playwright test collection and caused CI to report no tests ran.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants