Fixed an issue where upstream Electron fails to extract - #3836
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds an ChangesDependency version override
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/cherry-pick release-6.2 |
|
Cherry pick is scheduled. |
|
/cherry-pick release-5.13 |
|
Cherry pick is scheduled. |
|
Error trying doing the automated Cherry picking. Please do this manually |
…s suites Addresses @devinbinnie's review: the "Electron failed to install correctly" CI failure these mocks worked around was fixed upstream in #3836 (already in this branch), so the mocks are no longer needed. Reverted both suites to master; they pass against the real electron module. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Summary
An upstream issue with Electron's dependencies (electron/electron#51619) causes Node 24 to fail to extract the binary, causing tests to fail unexpectedly.
This PR adds an override for the library that was failing so that it will work on Node 24.
Change Impact: 🟢 Low
Regression Risk: Minimal. This change only adds a dependency override in
package.jsonto forceyauzlversion3.3.1, which is a build-time dependency used by Electron for binary extraction. No application code logic is modified, and the override is narrowly scoped to resolve a specific Node 24 compatibility issue with Electron's binary extraction process. The change does not affect runtime behavior, core logic, or shared utilities.QA Recommendation: Manual QA can be safely skipped for this change. Verification should focus on confirming that the build process completes successfully on Node 24 and that tests pass as expected (which appears to be the original issue being fixed). Automated build and test pipelines should provide sufficient validation.