Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-56795] Improve help options in the Help menu #3216

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

devinbinnie
Copy link
Member

Summary

This PR includes changes to the Help menu to better get users in the direction of support when necessary. We've removed the "Learn more" link and replaced with a set of server-configurable links that will send the users to the correct links. At the server level, if a user is on a server the links will update to whatever the server has configured, or if there's nothing configured a default will be used.

Ticket Link

https://mattermost.atlassian.net/browse/MM-56795

Screenshots

image\

Release Note

Improve help options in the Help menu

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester 1: UX Review Requires review by a UX Designer labels Nov 19, 2024
@devinbinnie devinbinnie added this to the v5.11.0 milestone Nov 19, 2024
@yasserfaraazkhan yasserfaraazkhan added Build Apps for PR Builds signed builds for testing Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Nov 20, 2024
Copy link

Here are the test results below:

Test Summary for Linux on commit 7c6c82d

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit 7c6c82d

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit 7c6c82d

All stable tests passed on Windows.

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 20, 2024
Copy link

Here are the test results below:

Test Summary for Linux on commit 7c6c82d

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit 7c6c82d

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit 7c6c82d

All stable tests passed on Windows.

@devinbinnie devinbinnie requested review from a team and gabrieljackson and removed request for a team November 20, 2024 14:36
@devinbinnie devinbinnie removed the 3: QA Review Requires review by a QA tester label Nov 20, 2024
Copy link

@abhijit-singh abhijit-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinbinnie, looks good! Just one request - can we remove the separator between Run diagnostics and Report a problem? I don't think we need a separate section for just Report a problem unless I'm missing something.

@devinbinnie devinbinnie removed the 1: UX Review Requires review by a UX Designer label Nov 21, 2024
@devinbinnie
Copy link
Member Author

Thanks @devinbinnie, looks good! Just one request - can we remove the separator between Run diagnostics and Report a problem? I don't think we need a separate section for just Report a problem unless I'm missing something.

Done :)

image

Copy link

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core committer label Nov 22, 2024
@devinbinnie devinbinnie added the 4: Reviews Complete All reviewers have approved the pull request label Nov 22, 2024
@devinbinnie devinbinnie merged commit 513a7e0 into master Nov 22, 2024
11 checks passed
@devinbinnie devinbinnie deleted the MM-56795 branch November 22, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Builds signed builds for testing release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants