Conversation
toninis
suggested changes
Mar 24, 2025
Contributor
toninis
left a comment
toninis
left a comment
There was a problem hiding this comment.
I would suggest to create a completely new reusable workflow for this . Since it's a PoC we do not want to integrate this in our production pipelines .
If it's approved in general as a tool we can discuss
Contributor
Author
I can work from this branch directly until that happens instead of duplicating the workflows, what do you think? |
Member
|
@fmartingr does this PR still make sense? |
Contributor
Author
|
Nope. closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change installs mage in the plugin pipelines adding an input to allow consumers to specify a version.
This was done on an effort to migrate our current
makeworkflows tomage: mattermost/mattermost-plugin-legal-hold#136