Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from CircleCI to Github Actions #72

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Migrate from CircleCI to Github Actions #72

merged 3 commits into from
Feb 7, 2023

Conversation

spirosoik
Copy link
Contributor 

    #### Summary
    The PR build (CI) is a reusable [required workflow](https://github.com/mattermost/actions-workflows/tree/main/.github/workflows/required_workflows/plugins)  

    #### Ticket Link
    Ticket: https://mattermost.atlassian.net/browse/CLD-4816

@spirosoik
Migrate from CircleCI to Github Actions
061b0cf 
        The PR build (CI) is a reusable [required workflow](https://github.com/mattermost/actions-workflows/tree/main/.github/workflows/required_workflows/plugins). The CD
        part is defined in the repository. In parallel we add the  to define the version of node we need to use to build.

        Ticket: https://mattermost.atlassian.net/browse/CLD-4816
@spirosoik spirosoik merged commit a643cf2 into master Feb 7, 2023
@spirosoik spirosoik deleted the feat/CLD-4816 branch February 7, 2023 09:42
hanzei
hanzei reviewed Feb 7, 2023
View reviewed changes
lock-missing.txt
@@ -0,0 +1 @@
mattermost-plugin-aws-SNS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Feb 7, 2023
@avas27JTG avas27JTG mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei left review comments

@m1lt0n m1lt0n m1lt0n approved these changes

@mickmister mickmister Awaiting requested review from mickmister

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spirosoik @m1lt0n @hanzei