[MM-98] Update plugin with respect to phase 1 upgrades#217
[MM-98] Update plugin with respect to phase 1 upgrades#217mickmister merged 6 commits intomattermost-community:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 39.95% 40.02% +0.07%
==========================================
Files 6 6
Lines 836 837 +1
==========================================
+ Hits 334 335 +1
Misses 482 482
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
@ayusht2810 Can we add the updates from this PR before merging these? mattermost/mattermost-plugin-starter-template#192. One important thing this does is allow RCs and debug builds to have a more descriptive version number |
| optDisableNonWordPrefix = "DisableNonWordPrefix" | ||
| optDisableNonWordSuffix = "DisableNonWordSuffix" | ||
| optWordMatch = "WordMatch" | ||
| newLine = "```n" |
There was a problem hiding this comment.
This is missing the backslash. Can you make sure the change works correctly? Alternatively, we can disable this linting check. I think I would prefer that, because this is a clear case where it's working against us and not providing much value
Also, there is more going on here than a "new line". We're also closing a code block
mattermost-community#192) * Revert "Update main.go (mattermost-community#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (mattermost-community#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (mattermost-community#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
|
@mickmister fixed the review comments. Please re-review. |
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
The above PR has been tested for all the basic functionalities and the slash commands and it was found working fine, LGTM. Approved.
mickmister
added
4: Reviews Complete
6 participants
Summary
Updated plugin with respect to phase 1 upgrades
buildfolder to sync with starter templatenvmrcfile.Ticket Link