Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.4.0 #203

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Release v1.4.0 #203

merged 2 commits into from
Mar 23, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Dec 2, 2022

Summary

Release for #201

Ticket Link

Part of #202

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 2, 2022
@hanzei hanzei added this to the v1.4.0 milestone Dec 2, 2022
@hanzei hanzei requested a review from levb as a code owner December 2, 2022 09:44
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a68c6d) 40.09% compared to head (cf0b3bb) 40.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   40.09%   40.09%           
=======================================
  Files           6        6           
  Lines         833      833           
=======================================
  Hits          334      334           
  Misses        479      479           
  Partials       20       20           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@m1lt0n m1lt0n changed the title Releas v1.4.0 Release v1.4.0 Feb 1, 2023
@hanzei hanzei mentioned this pull request Feb 15, 2023
1 task
@hanzei hanzei removed the request for review from levb February 15, 2023 20:34
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Feb 15, 2023
@hanzei hanzei self-assigned this Feb 15, 2023
@DHaussermann
Copy link

@mickmister or @hanzei I'm running through the release test now but, I wonder why there is no CI for build?

For release testing as a precaution, I like to use the binary that came from the pipeline instead of compiling locally. Does CI produce a build here I can use?

@mickmister
Copy link
Contributor

/update-branch

@mickmister
Copy link
Contributor

@DHaussermann The branch needed an update to have the github action workflows. Check the bottom of this page for the built plugin https://github.com/mattermost/mattermost-plugin-autolink/actions/runs/4437991164?pr=203

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Reviewed code changes since last release
  • Added one test to cover a functional change
  • Ran through all tests in Zephyr
  • No new issues found
  • As a precaution ran the binary from the pipeline on both a Mac OS hosted Mattermost instance as well as our Cloud infrastructure
  • Version bump is correct at 1.4.0

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 22, 2023
@hanzei hanzei merged commit 720fe5e into master Mar 23, 2023
@hanzei hanzei deleted the release_v1.4.0 branch March 23, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants