Fixed a bug causing double scroll bars to appear #2217
Conversation
harshilsharma63
requested review from
chenilim
and removed request for
a team
| @@ -46,3 +46,7 @@ | |||
| width: 600px; | |||
| height: 468px; | |||
| } | |||
|
|
|||
| .mainContentRow { | |||
| height: calc(100% - 40px); | |||
There was a problem hiding this comment.
@harshilsharma63 should this fix be applied in mattermost/webapp repo? This class name is not used in focalboard sources.
There was a problem hiding this comment.
@kamre no it should not be in webapp. The issue is only with focalboard and not other products. The main cause of this issue is the sidebar but after spending about half an hour, I couldn't figure out what was causing the issue. This CSS change fixes it, though not the 100% ideal solution.
There was a problem hiding this comment.
@harshilsharma63 but if the class name mainContentRow will be renamed in mattermost/webapp then this will require to update focalboard repo. Also just changing this 40px will also require an update here in focalboard repo inside this calc expression.
Looks like this styling is tightly coupled to mattermost/webapp repo. And this file boardPage.scss is not even inside the plugin code. So may be the issue with styling should be resolved in mattermost/webapp repo.
One more notice: for Playbooks that height: 100% for mainContentRow doesn't look correct, but root component in case of Playbooks has overflow hidden and there is no scroll bar.
There was a problem hiding this comment.
I'm aware of this. I'll update the styling later. We're making a lot of changes to the sidebar in a separate feature branch so I don't want to spend much time here knowing the whole component is gonna change a few weeks later.
This reverts commit 55879bd.
Summary
Fixed a bug causing double scroll bars to appear
Ticket Link
Fixes #2211