Skip to content

refactor(integration-tests): simplify test harness#1183

Closed
romanbrodetski-ai wants to merge 1 commit into
matter-labs:mainfrom
romanbrodetski-ai:rb-it-harness-derived-config
Closed

refactor(integration-tests): simplify test harness#1183
romanbrodetski-ai wants to merge 1 commit into
matter-labs:mainfrom
romanbrodetski-ai:rb-it-harness-derived-config

Conversation

@romanbrodetski-ai
Copy link
Copy Markdown
Contributor

@romanbrodetski-ai romanbrodetski-ai commented Apr 19, 2026 •
edited by RomanBrodetski
Loading

Summary

Testing

  • cargo test -p zksync_os_integration_tests --no-run
  • cargo nextest run -p zksync_os_integration_tests --profile no-pig

@romanbrodetski-ai
Copy link
Copy Markdown
Contributor Author

romanbrodetski-ai commented Apr 19, 2026

Potential correctness issue: for NEXT_TO_GATEWAY, restarting the primary tester looks like it drops the supporting gateway runtime. TestEnvironment::launch() stores the gateway as an owned supporting node, but Tester::stop() drops supporting nodes and StoppedTester::start_with_config() does not recreate them, so a restarted tester may keep gateway_rpc_url pointing at a gateway process that has already been shut down.

@romanbrodetski-ai romanbrodetski-ai force-pushed the rb-it-harness-derived-config branch from 70e3b94 to 03053d8 Compare April 19, 2026 15:08
perekopskiy
perekopskiy reviewed Apr 20, 2026
View reviewed changes
Comment thread integration-tests/tests/upgrade/mod.rs
Copy link
Copy Markdown
Contributor

@perekopskiy perekopskiy Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please elaborate on upgrade test changes, because I don't follow

Copy link
Copy Markdown
Collaborator

@RomanBrodetski RomanBrodetski Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were more complex than needed. Now fixed. Thanks for flagging!

Comment thread Cargo.toml
reth-provider = { git = "https://github.com/paradigmxyz/reth", tag = "v1.11.1" }
reth-rpc-eth-types = { git = "https://github.com/paradigmxyz/reth", tag = "v1.11.1" }
reth-tasks = { git = "https://github.com/paradigmxyz/reth", tag = "v1.11.1" }
reth-db-models = { git = "https://github.com/romanbrodetski-ai/reth.git", branch = "fix/discv5-shutdown-v1.11.1" }
Copy link
Copy Markdown
Contributor

@perekopskiy perekopskiy Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's that?

Copy link
Copy Markdown
Collaborator

@RomanBrodetski RomanBrodetski Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to PR descrtiption - we use reth fork with a fix that makes ssure the port is released when networking is tore down. This is needed to properly test node restart behaviour in int. tests.

@romanbrodetski-ai romanbrodetski-ai force-pushed the rb-it-harness-derived-config branch 2 times, most recently from 9ce2f64 to 7da7821 Compare April 21, 2026 13:53
@romanbrodetski-ai romanbrodetski-ai force-pushed the rb-it-harness-derived-config branch from 7da7821 to e358de3 Compare April 21, 2026 16:22
@RomanBrodetski
Copy link
Copy Markdown
Collaborator

RomanBrodetski commented Apr 21, 2026

Moved to https://github.com/matter-labs/zksync-os-server/pull/1191/changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomanBrodetski RomanBrodetski RomanBrodetski left review comments

@perekopskiy perekopskiy perekopskiy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romanbrodetski-ai @RomanBrodetski @perekopskiy