Conversation
dutterbutter
approved these changes
Jan 24, 2025
Collaborator
@nbaztec we can look at removing, initially wanted to keep as I havent reviewed if folks rely on it in anyway. Upstream has it the same so we can review and look to remove if not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What 💻
IS_NIGHTLYdetection.Why ✋
Evidence 📷
Action runs
https://github.com/matter-labs/foundry-zksync/actions/runs/12950423332/job/36123203197
https://github.com/matter-labs/foundry-zksync/actions/runs/12950402414/job/36123129539
Documentation 📚
Please ensure the following before submitting your PR:
Notes 📝
We're currently using
include-component-in-tag = truein release-please so our stable tags come out asfoundry-zksync-v0.0.4meanwhile nightly tags arenightly-{{sha}}, this is all good but if we don't need the component we should look into removing that part. @dutterbutter