Allow specifying X and Y position of frame #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
useful, thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Noticed that the X and Y position of the frame was hardcoded to 0 in issue #11 and needed it for a gif generator to really get file sizes down, so I went ahead and added it to the options object and plumbed it through to
encodeImageDescriptor. Works for what I needed but didn't test it super thoroughly!Thanks for creating the library otherwise, our dumb joke Discord bot has a lot of plugins that generate animated GIFs and gifenc was consistently the best library for us to get generation times down, and also optimize file sizes.