Include t3a.micro in compute.yaml #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
approved these changes
Jul 11, 2024
alinabuzachis
approved these changes
Jul 11, 2024
gravesm
reviewed
Jul 11, 2024
There was a problem hiding this comment.
The compute policy is too big. At this point, there's nothing obvious to trim down. I think I would recommend replacing all the delete permissions for autoscaling in the AllowGlobalResourceRestrictedActionsWhichIncurNoFees with autoscaling:Delete*. The only new permission this adds is the ability to delete warm pools, and I think that's fine.
gravesm
approved these changes
Jul 11, 2024
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 11, 2024
) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
patchback bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 11, 2024
) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit 2f1fcab)
patchback bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 11, 2024
) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit 2f1fcab)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 12, 2024
) (#2190) This is a backport of PR #2188 as merged into main (2f1fcab). SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Jul 12, 2024
) (#2189) This is a backport of PR #2188 as merged into main (2f1fcab). SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds t3a.micro instance type to aws/policy/compute.yaml
Refer: https://issues.redhat.com/browse/ACA-1691