Remove default bundler_jobs value (4) in favor of letting Bundler (2.2+) choose it automatically#147
Merged
mattbrictson merged 1 commit intomainfrom Dec 27, 2020
Conversation
mattbrictson
changed the title
Owner
Author
|
Actually, the automatic configuration of jobs is only enabled for Bundler 3+. Let's keep the default for now. |
Owner
Author
|
Reopening because the automatic configuration of jobs is coming soon with Bundler 2.2: https://github.com/rubygems/rubygems/releases/tag/bundler-v2.2.0.rc.1 |
mattbrictson
changed the title
mattbrictson
force-pushed
the
features/remove-bundler-jobs-default
branch
from
9793775 to
ea44ea2
Compare
mattbrictson
force-pushed
the
features/remove-bundler-jobs-default
branch
from
ea44ea2 to
44ff187
Compare
mattbrictson
force-pushed
the
features/remove-bundler-jobs-default
branch
from
44ff187 to
3a7b914
Compare
mattbrictson
force-pushed
the
features/remove-bundler-jobs-default
branch
from
3a7b914 to
63ec7fe
Compare
Bundler will automatically determine the "best" value to use for the jobs options based on the number of processors, so there is no need to specify a value. Especially an arbitrary value of "4" that may not make sense depending on the machine where bundler is being used. This commit removes tomo's default value of the `bundler_jobs` setting so that Bundler's built-in behavior will be used instead. The `bundler_jobs` setting is still supported if tomo user's want to provide a specific value.
mattbrictson
force-pushed
the
features/remove-bundler-jobs-default
branch
from
63ec7fe to
a800a46
Compare
mattbrictson
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Bundler 2.2, Bundler will automatically determine the "best" value to use for the jobs options based on the number of processors, so there is no need to specify a value. Especially an arbitrary value of "4" that may not make sense depending on the machine where bundler is being used.
This commit removes tomo's default value of the
bundler_jobssetting so that Bundler's built-in behavior will be used instead. Thebundler_jobssetting is still supported if tomo users want to provide a specific value.If you are upgrading tomo and wish to retain the old default, add this to your config: