Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scroll bar on main window #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bliz937
Copy link

@bliz937 bliz937 commented Sep 5, 2017

No description provided.

ghost
ghost previously approved these changes Sep 24, 2017
@tatokis tatokis self-requested a review September 24, 2017 18:02
@ghost ghost self-requested a review September 24, 2017 18:16
@ghost ghost dismissed their stale review September 24, 2017 18:16

Further UI problems have occurred, investigating whether it is connected to this PR or not.

@ghost
Copy link

ghost commented Oct 6, 2017

Actually, comparing it to master, the level of GUI brokenness [for me] has remained just about the same, the only issue is all the area being active instead of just a tab, which [I guess] will make it unavailable for screen readers, but since the GUI is already not usable with them (there is a ticket that I can't find at the time of writing this), this is acceptable as of now.

master:

Your branch:

@tatokis
Copy link
Collaborator

tatokis commented Nov 11, 2017

Right, since we need to get this over with.
Based on your modifications, I turned off the extra borders and removed any extra padding, however it seems to cause issues on high DPI screens.

I am not really sure how to proceed at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants