Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying --write-pre-masked shouldn't prevent placement #319

Closed
metasoarous opened this issue Nov 5, 2013 · 5 comments
Closed

Specifying --write-pre-masked shouldn't prevent placement #319

metasoarous opened this issue Nov 5, 2013 · 5 comments

Comments

@metasoarous
Copy link
Collaborator

Currently, when this flag is specified, pplacer seems to write out the pre-masked alignment, then halt, never going on to actually produce a placefile.

matsen pushed a commit that referenced this issue Nov 6, 2013
I guess AD had his reasons for this.
@matsen
Copy link
Owner

matsen commented Nov 6, 2013

Closed by 480c7ea

@matsen matsen closed this as completed Nov 6, 2013
@cmccoy
Copy link
Collaborator

cmccoy commented Nov 6, 2013

The old behavior was as-documented:

--write-pre-masked
    Write out the pre-masked sequences to the specified fasta file and exit.

@cmccoy cmccoy reopened this Nov 6, 2013
@matsen
Copy link
Owner

matsen commented Nov 6, 2013

Huh, indeed. Well, the reason I wanted to change it rather than leave it be was to make its operation more consistent with the other masking-writing options.

What do you think-- update docs or back up some commits and forget it entirely?

@cmccoy
Copy link
Collaborator

cmccoy commented Nov 6, 2013

Updating docs sounds good to me.

On Tue, Nov 5, 2013 at 7:02 PM, Erick Matsen [email protected]:

Huh, indeed. Well, the reason I wanted to change it rather than leave it
be was to make its operation more consistent with the other masking-writing
options.

What do you think-- update docs or back up some commits and forget it
entirely?


Reply to this email directly or view it on GitHubhttps://github.com//issues/319#issuecomment-27838118
.

@matsen
Copy link
Owner

matsen commented Nov 6, 2013

Re-closed by eda4442 . Thanks, Connor.

@matsen matsen closed this as completed Nov 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants