Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Component composition > Context for Qwik #155

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented Feb 14, 2023

The render app and context sample for qwik was missing.

@JohnsonMao JohnsonMao changed the title Add Webapp features > Render app for Qwik Add Render app and Context for Qwik Feb 15, 2023
@matschik
Copy link
Owner

matschik commented Mar 4, 2023

We don't need the router part, we only want the SPA render part and nothing else.
The goal is to just render a single component in a simple HTML file.

@JohnsonMao
Copy link
Contributor Author

JohnsonMao commented Mar 6, 2023

Okay, it seems that Qwik does not offer the ability to implement SPA functionality through a single HTML file.
I will proceed to edit the existing PR to merge the context changes.

@JohnsonMao JohnsonMao reopened this Mar 7, 2023
@JohnsonMao JohnsonMao changed the title Add Render app and Context for Qwik Add Component composition > Context for Qwik Mar 7, 2023
@matschik matschik merged commit baec35a into matschik:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants