Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update go to 1.24 #233

Merged
merged 3 commits into from
Feb 13, 2025
Merged

build: Update go to 1.24 #233

merged 3 commits into from
Feb 13, 2025

Conversation

itkq
Copy link
Contributor

@itkq itkq commented Feb 13, 2025

With go 1.24, go install github.com/matryer/moq@latest works but binaries from https://github.com/matryer/moq/releases/tag/v0.5.2 doesn't work.

package requires newer Go version go1.24 (application built with go1.23)

@itkq itkq marked this pull request as ready for review February 13, 2025 05:43
@sudo-suhas
Copy link
Collaborator

Could you also update release.yml workflow similar to https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases to use the stable release for building the binaries?

@itkq
Copy link
Contributor Author

itkq commented Feb 13, 2025

Updated release.yml to use stable alias.

@sudo-suhas sudo-suhas merged commit 31af695 into matryer:main Feb 13, 2025
4 checks passed
@sudo-suhas
Copy link
Collaborator

sudo-suhas commented Feb 13, 2025

Released via v0.5.3 🎉

Thanks @itkq for the fix!

@itkq
Copy link
Contributor Author

itkq commented Feb 13, 2025

Thank you for quick response!

@itkq itkq deleted the update-go-1.24 branch February 13, 2025 08:48
@hazzik
Copy link

hazzik commented Feb 13, 2025

Thats, unfortunately a breaking change and should have not been released as a patch version

@sudo-suhas
Copy link
Collaborator

Thanks for pointing out @hazzik. I should have tagged it as v0.6.0. I will try to ensure I don't repeat this mistake in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants