Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use r0 instead of 'unstable' for joined_members|rooms #834

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Mar 18, 2020

Dendrite is implementing these APIs and these APIs are already in
the r0 spec, so we should be testing against r0 and not unstable.

Dendrite is implementing these APIs and these APIs are already in
the r0 spec, so we should be testing against r0 and not unstable.
@kegsay
Copy link
Member Author

kegsay commented Mar 18, 2020

LOOK AT HOW GREEN IT IS

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another instance of /unstable/joined_rooms here that we should change:

uri => "/unstable/joined_rooms",

and /unstable.../joined_members here:

uri => "/unstable/rooms/$room_id/joined_members",

@kegsay
Copy link
Member Author

kegsay commented Mar 18, 2020

Thanks!

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREEN ACHIEVED!

@kegsay kegsay merged commit aaac4f5 into develop Mar 18, 2020
@kegsay kegsay deleted the kegan/joined-room-r0 branch March 18, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants