Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use Redis with Synapse workers. #1282

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Conversation

clokep
Copy link
Member

@clokep clokep commented Aug 26, 2022

Prep work for matrix-org/synapse#11728.

@clokep clokep force-pushed the clokep/rm-replication-config branch from b7261c1 to 3bd1089 Compare August 26, 2022 14:37
@clokep clokep marked this pull request as ready for review August 26, 2022 15:00
@clokep clokep requested a review from a team as a code owner August 26, 2022 15:00
docker/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@H-Shay H-Shay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with the caveat that my perl is not fluent so my approval is about 50% "I can decipher what you're doing and it seems reasonable" and 50% "the tests work and I trust you" wrt to the ha proxy changes

@clokep clokep merged commit c84670c into develop Aug 26, 2022
@clokep clokep deleted the clokep/rm-replication-config branch August 26, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants