[pyupgrade] groups/, federation/, events/, and crypto/

[ShadowJonathan]

Part of #9744

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
• Pull request includes a sign off
• Code style is correct (run the linters)

Signed-off-by: Jonathan de Jong <[email protected]>

[ShadowJonathan]

This'll be the newsfile that i will use across all pyupgrade PRs, any adjustments?

[ShadowJonathan]

I'm opening this one - the smallest PR out of the bunch - first, so that any misunderstandings and gotchas can be caught on this one first, before they'd happen across other PRs.

[clokep]

Just to reconfirm, this is equivalent to running pyupgrade --py36-plus synapse/groups synapse/federation synapse/events synapse/crypto? I.e. all changes are automated from pyupgrade?

[ShadowJonathan]

Yes, though it's more akin to running find $1 -type f -name "*.py" on each, as the command doesn't recurse into directories (many PRs requesting such feature nonwithstanding)

I also ran scripts-dev/lint.sh after it, and some complaints from that weren't automatically fixed (# of empty lines before class declarations with comments) on some of the other PRs, but yes, every change is automated.

[ShadowJonathan]

Closed in favour of better refactoring methodology, see #9744