Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Only send catch up events if they're the latest in the room #9621

Closed
wants to merge 2 commits into from

Conversation

erikjohnston
Copy link
Member

This is a bit of a hack to help mitigate #9492. One of the problems there is that in a busy with lots of servers, each server will send the last event they sent, which results in the server that has come back online getting a smattering of events rather than just the latest event its missed. The flip side is that it relies on whatever server that did send the last event in the room actually sending that to the newly up server.

I'm not really sure if this is what we want to do. Other thing we could do is add more metadata to the sent event to help the remote Do The Right Thing, or simply send the current forward extremities of the room to them (though currently servers drop events they get via /send from other servers).

Thoughts?

@erikjohnston erikjohnston requested a review from a team March 15, 2021 16:50
@erikjohnston
Copy link
Member Author

or simply send the current forward extremities of the room to them (though currently servers drop events they get via /send from other servers).

After some talk in #synapse-dev:matrix.org, I'll give this a go

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant