This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint to get an event at a given timestamp - MSC3030 #9445
Add endpoint to get an event at a given timestamp - MSC3030 #9445
Changes from 11 commits
91b1b36
8e5fa11
96c48ba
668aa4e
5b07487
f721899
af085ab
065273b
0e0ddda
e321ef7
e21e4b5
fa15989
ec2695d
22a93c3
b311853
5638123
612b51f
654d7ae
6280d36
8766b0a
86a2642
5a2c997
bc3ba38
edac953
ab800e3
9800a4b
8523bf3
f05c292
984a14b
dae7e0a
87ac1ed
2a5b622
0610fac
183e1bf
5362bd3
76ac526
58d67f2
63d61fc
70420e5
a8644b9
c38984c
ed1360a
13371a6
d137292
662366a
dd7e689
e7d2120
5660fde
c3c404b
1ff2db4
067d67a
5888eba
68704f4
3ee5d0c
2621e5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem I'm seeing with going with a
/timestamp_to_event
endpoint is that there is no way to actually paginate with/messages
after getting theevent_id
.We probably want to consider also returning a pagination stream token to use with the
from
/to
on/messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just not worry about it, we can make a separate request to get one:
https://github.com/matrix-org/complement/blob/581cb0b26e602763c4ec52e3c5f5047a2a4d95b7/tests/msc2716_test.go#L1323-L1326