This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Begin to phase out use of event_json
, rejections
and state_events
#9413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to collect all the stuff that is commonly selected together into one table, rather than having it scattered around the filesystem.
I benchmarked the new
_fetch_event_rows
query based on 100 queries I pulled out of my slow query log. On my I/O constrained server, it reduced the average time taken to fetch a batch of events from 9.7 seconds to 5.4 seconds.Unfortunately I don't have good metrics for how much storage increased by, but I don't think it was that bad (like 2%).
Obviously, we will need a background update to populate the new columns. I'm mostly floating this to gather comments at this stage.
Based on #9411.