Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up caching/locking of OIDC metadata load #9362

Merged
merged 6 commits into from
Feb 16, 2021

Commits on Feb 10, 2021

  1. Implement a CachedCall to handle boilerplate of caching results

    This is a relatively common pattern which is hard to get right.
    richvdh committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    586f11d View commit details
    Browse the repository at this point in the history
  2. Tiny cleanup to validate_metadata

    `validate_jwks_uri` already checks that `jwks_uri` is set.
    richvdh committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    51d689a View commit details
    Browse the repository at this point in the history
  3. Stop caching the JWKS in provider_metadata

    AFAICT from the RFCs (https://tools.ietf.org/html/rfc8414), `jwks` is not a
    field that can be returned from the metadata endpoint, so this is entirely an
    internal cache. The object is opaque enough without us inventing extra things
    to store in it, so let's move it out.
    richvdh committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9eedff8 View commit details
    Browse the repository at this point in the history
  4. Clean up caching/locking of OIDC metadata load

    Ensure that we lock correctly to prevent multiple concurrent metadata load
    requests, and generally clean up the way we construct the metadata cache.
    richvdh committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7da0f08 View commit details
    Browse the repository at this point in the history
  5. changelog

    richvdh committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8ecc099 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. remove redundant annotation

    richvdh committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8125baa View commit details
    Browse the repository at this point in the history