Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Give the user a better error when they present bad SSO creds #9091

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Give the user a better error when they present bad SSO creds #9091

merged 3 commits into from
Jan 15, 2021

Commits on Jan 13, 2021

  1. Give the user a better error when they present bad SSO creds 

    If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO
IdP, try to give them a better error.

Previously, the UIA would claim to be successful, but then the operation in
question would simply fail with "auth fail". Instead, serve up an error page
which explains the failure.
    @richvdh
    richvdh committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    5310808 View commit details
    Browse the repository at this point in the history

  2. Move complete_sso_ui_auth into SSOHandler 

    since we're hacking on this code anyway, may as well move it out of the
cluttered AuthHandler.
    @richvdh
    richvdh committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    4200319 View commit details
    Browse the repository at this point in the history

  3. Add a test for wrong user returned by SSO

    @richvdh
    richvdh committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    26d1033 View commit details
    Browse the repository at this point in the history