Sync ignored table names in synapse_port_db to current database schema #7717
Conversation
|
I don't know if we need to keep the older table names as well for backwards compatibility? I don't think so since the script ensures that all schema deltas have been applied before running. |
richvdh
changed the title
clokep
changed the title
| "user_directory_search_content", | ||
| "user_directory_search_docsize", | ||
| "user_directory_search_segdir", | ||
| "user_directory_search_segments", | ||
| "user_directory_search_stat", | ||
| "user_directory_search_pos", |
There was a problem hiding this comment.
I'm not sure if all of these are regenerated or not...I might be totally off base here.
There was a problem hiding this comment.
I think a bunch of these are actually sqlite specific stuff anyway (to support full text search)
There was a problem hiding this comment.
That means we should include them, correct?
| "users_who_share_private_rooms", | ||
| "users_in_public_room", |
There was a problem hiding this comment.
These two tables were renamed at some point, I believe.
There was a problem hiding this comment.
Looks like they were. They're regenerated because somewhere later in the port code we explicitly reset the entry in the user_directory_stream_pos table
changelog.d/7717.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Sync the list of tables ignored by `synapse_port_db` with the current database schema. | |||
There was a problem hiding this comment.
Can you word this as Fix.... please?
There was a problem hiding this comment.
Done! Thanks for the review!
* commit 'dc80a0762': 1.16.0rc1 Back out MSC2625 implementation (#7761) Additional configuration options for auto-join rooms (#7763) Add some metrics for inbound and outbound federation processing times (#7755) Explain the purpose of the "tests" conditional dependency requirement (#7751) Add another yield point to state res v2 (#7746) Move flake8 to end. Don't exit script on failure (#7738) Make tox actions work on Debian 10 (#7703) Yield during large v2 state res. (#7735) add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675) Set Content-Length for Metrics requests (#7730) Sync ignored table names in synapse_port_db to current database schema (#7717) Allow local media to be marked as safe from being quarantined. (#7718) Convert directory handler to async/await (#7727) Speed up state res v2 across large state differences. (#7725)
Noticed in #7711, it seems some of the tables we ignore in
synapse_port_dbdon't exist anymore. I took a try at syncing the list to the real tables.