This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dev script to generate full SQL schema files #6394
Add dev script to generate full SQL schema files #6394
Changes from 7 commits
9415dda
f6eff4b
a6e0c40
9b6e8e2
be14648
6f818ef
9b7d574
1a768ec
cb78f36
495cde7
eae3127
6a93bd1
d125d18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what happens if you don't set this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks for
test.signing.key
in the current directory, not the temp dir.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a bug. It's due to
config_dir_path
being""
here:synapse/synapse/config/key.py
Line 97 in 54fef09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, that doesn't sound right. Ok, let's not get distracted by going on a bughunt now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
^SELECT
lines has the unfortunate side effect of removingNote that passing
true
tosetval
marks the set value as having been used, so thatnextval
will be larger. https://www.postgresql.org/docs/current/functions-sequence.htmlThis probably explains #13873 (comment).
This file was deleted.