Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement soft fail #4814

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Implement soft fail #4814

merged 4 commits into from
Mar 8, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Mar 6, 2019

@erikjohnston erikjohnston marked this pull request as ready for review March 6, 2019 16:28
@erikjohnston erikjohnston requested a review from a team March 6, 2019 16:28
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #4814 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4814      +/-   ##
===========================================
+ Coverage    75.35%   75.36%   +0.01%     
===========================================
  Files          340      340              
  Lines        34889    34920      +31     
  Branches      5708     5717       +9     
===========================================
+ Hits         26290    26317      +27     
- Misses        6988     6991       +3     
- Partials      1611     1612       +1

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although _prep_event is now pretty huge. Would it be possible to factor the new stuff out?

@erikjohnston erikjohnston merged commit 39e57f9 into develop Mar 8, 2019
@erikjohnston erikjohnston deleted the erikj/soft_fail_impl branch January 9, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants