-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Notes on upgrading to python3, and README updates. #4260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale on changing the virtualenv directories?
virtualenv -p python2.7 ~/.synapse | ||
source ~/.synapse/bin/activate | ||
mkdir -p ~/synapse | ||
virtualenv -p python3 ~/synapse/env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does python3 recommend using the venv module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfamiliar with the venv module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a standard library equivalent to virtualenv, but probably fine to stick with virtualenv
for now
It always struck me that putting them in a hidden directory was odd, and I don't know why we recommend it. I thought I'd clean it up while we were here. |
Its a bit rude to be adding bits directly to the home directory, but eh, I guess if people care then they can change it when following the instructions |
Codecov Report
@@ Coverage Diff @@
## develop #4260 +/- ##
===========================================
+ Coverage 73.51% 73.52% +0.01%
===========================================
Files 298 298
Lines 29819 29819
Branches 4881 4881
===========================================
+ Hits 21921 21925 +4
+ Misses 6460 6458 -2
+ Partials 1438 1436 -2
Continue to review full report at Codecov.
|
No description provided.