Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Notes on upgrading to python3, and README updates. #4260

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 4, 2018

No description provided.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale on changing the virtualenv directories?

virtualenv -p python2.7 ~/.synapse
source ~/.synapse/bin/activate
mkdir -p ~/synapse
virtualenv -p python3 ~/synapse/env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does python3 recommend using the venv module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with the venv module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a standard library equivalent to virtualenv, but probably fine to stick with virtualenv for now

@richvdh
Copy link
Member Author

richvdh commented Dec 4, 2018

What's the rationale on changing the virtualenv directories?

It always struck me that putting them in a hidden directory was odd, and I don't know why we recommend it. I thought I'd clean it up while we were here.

@erikjohnston
Copy link
Member

What's the rationale on changing the virtualenv directories?

It always struck me that putting them in a hidden directory was odd, and I don't know why we recommend it. I thought I'd clean it up while we were here.

Its a bit rude to be adding bits directly to the home directory, but eh, I guess if people care then they can change it when following the instructions

@codecov-io
Copy link

Codecov Report

Merging #4260 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4260      +/-   ##
===========================================
+ Coverage    73.51%   73.52%   +0.01%     
===========================================
  Files          298      298              
  Lines        29819    29819              
  Branches      4881     4881              
===========================================
+ Hits         21921    21925       +4     
+ Misses        6460     6458       -2     
+ Partials      1438     1436       -2
Impacted Files Coverage Δ
synapse/app/homeserver.py 57.28% <0%> (+0.33%) ⬆️
synapse/state/v1.py 92.24% <0%> (+1.55%) ⬆️
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b164241...4acd1a3. Read the comment docs.

@richvdh richvdh merged commit a2ed0f2 into develop Dec 4, 2018
@richvdh richvdh deleted the rav/python3 branch December 6, 2018 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants