This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Search: Add prefix matching support #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/search
branch
from
40af65e
to
477da77
Compare
| that can be passed to `to_tsquery(..)` postgres func. We use this so that | ||
| we can add prefix matching, which isn't something `plainto_tsquery` supports. | ||
| """ | ||
| results = re.findall(r"([\w\-]+)", search_term, re.UNICODE) |
There was a problem hiding this comment.
For the benefit of us who aren't familiar with regexeps it might be worth explaining what this code is doing.
Also since it is duplicated with the for sqlite below it might be worth lifting it out of these functions and moving it to the call site.
|
@NegativeMjark How about that? |
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Dec 2, 2015
Search: Add prefix matching support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.