This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Adjust event auth rules when there is no PL event #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it makes it easier for me to reason about
stop pretending that it returns a boolean, which just almost gave me a heart attack.
Make it so that, before there is a power-levels event in the room, you need a power level of at least 50 to send state. Partially addresses https://github.com/matrix-org/matrix-doc/issues/1192
We need power levels for this test to do what it is supposed to do.
|
@matrixbot retest this please |
|
taking an executive decision to merge this |
richvdh
added a commit
that referenced
this pull request
Jun 14, 2018
SECURITY UPDATE: Prevent unauthorised users from setting state events in a room when there is no `m.room.power_levels` event in force in the room. (PR #3397) Discussion around the Matrix Spec change proposal for this change can be followed at matrix-org/matrix-spec-proposals#1304.
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 31, 2018
This (belatedly) adds a test that the attack fixed in matrix-org/synapse#3397 is fixed.
richvdh
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Apr 5, 2023
There was substantial confusion around this, but I've done some archaeology. Basically, this was changed back in r0.5.0 by MSC1304 and matrix-org/synapse#3397. Before that, it was indeed the case that state_default was 0 if there was no m.room.power_levels event, but that was confusing and a source of security holes, so we changed it. matrix-org/matrix-spec-proposals#1656 changed the spec, but apparently overlooked the text in the description. Reverts: #1478. Fixes: #861.
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…org#1479) There was substantial confusion around this, but I've done some archaeology. Basically, this was changed back in r0.5.0 by MSC1304 and matrix-org/synapse#3397. Before that, it was indeed the case that state_default was 0 if there was no m.room.power_levels event, but that was confusing and a source of security holes, so we changed it. matrix-org/matrix-spec-proposals#1656 changed the spec, but apparently overlooked the text in the description. Reverts: matrix-org#1478. Fixes: matrix-org#861.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per matrix-org/matrix-spec-proposals#1304, make it so that, before there is a power-levels event in the room, you need a power level of at least 50 to send state.