remove obsolete webclient #2601

krombel · 2017-10-28T05:40:00Z

This got requested several times as in #1527

This introduces a homepage which is located at /_matrix/static/ and redirects the old webclient-path (/_matrix/client) to that path as well if the webclient is enabled
Why /_matrix/static/ is used is described in the commit-description of ba0c18e

This would close #1527, #1883, #2113 and indirectly #1250 and #1353

Signed-Off-by: Matthias Kesler [email protected]

matrixbot · 2017-10-28T05:40:02Z

Can one of the admins verify this patch?

matrixbot · 2017-10-28T05:40:02Z

Can one of the admins verify this patch?

maxidorius · 2017-10-28T23:36:01Z

@krombel What about the following concerns:

This leaks HS domains to a 3rd-party organization by default
Whatever website is used might be blocked or become obsolete

What about showing a page to the user instead, explaining it has been removed and why?

turt2live · 2017-10-29T00:07:08Z

or as per #1527 give some kind of page that says "Congratulations! You have synapse running!"

krombel · 2017-10-30T11:38:04Z

So you would prefer to

use a "Congratulations" page for /
show a descriptive page for the "old" webclient URL instead of redirecting?

maxidorius · 2017-10-30T11:40:59Z

/ and old webclient URL should show the same thing, which would ideally be a "Get started" page, pointing to clients, useful rooms for synapse, support channels, etc.

Ideally, the oldwebclient URL would redirect to /

krombel · 2017-10-30T11:59:54Z

So some page that mixes matrix.to and the homepage of riot (for the rooms), correct?

But: I do not know if it is good to introduce another site that would need updates from time to time.
Especially as synapse is going to be replaced by dendrite and the focus will move away from synapse.

So I think it might be enough to have a page that just links to matrix.org and matrix.to instead of a page that contains those information

maxidorius · 2017-10-30T12:25:08Z

So some page that mixes matrix.to and the homepage of riot (for the rooms), correct?

No, just links to helpful pages, like the Try Matrix one. As you pointed out, you don't want to have to update this often.

So I think it might be enough to have a page that just links to matrix.org and matrix.to instead of a page that contains those information

Yes, definitely.

somehow this introduced the bug that synapse tried to handle all URL's to be relative to STATIC_PREFIX so all endpoints got not handled any longer. This commit introduces a redirect to `/_matrix/static` where the homepage gets automatically served to circumvent this bug.

turt2live · 2017-12-18T01:28:15Z

An interesting problem is that the spec actually says there needs to be a web client: https://matrix.org/docs/spec/client_server/r0.3.0.html#login-fallback

It feels kinda weird to say in the spec that a small webapp has to be published. Instead, the spec should be updated to get rid of that in my opinion.

…ebclient

krombel · 2018-01-16T13:31:15Z

related Spec-PR: matrix-org/matrix-spec-proposals#1105

t3chguy · 2018-01-16T13:35:04Z

synapse/static/index.html

+       <p>For questions about synapse or matrix, please visit <br />
+       <a href="https://matrix.to/#/#synapse-community:matrix.org">#synapse-community:matrix.org</a> or
+       <a href="https://matrix.to/#/#matrix:matrix.org">#matrix:matrix.org</a>.</p>
+       <p>Welcome in the matrix-universe :)</p>


t3chguy · 2018-01-16T13:35:35Z

synapse/static/index.html

+       <h1>Synapse is running</h1>
+       <p>Congratulations!</p>
+       <p>Your Synapse server is listening on this port and is ready for messages.</p>
+       <p>To use this matrix-server you'll need a client to use this server - e.g. one of


seems duplicative, """to use this server you need a client to use this server"""

dbkr

This also removes the login fallback which is unrelated to the angular client.

krombel · 2018-01-18T11:30:46Z

So do I understand it right that the fallback should stay and the angular client be removed?
In other words: Just remove the dependency to matrix_angular_sdk but let the files at
synapse/static/client/login/* (and synapse/static/client/register/?)

dbkr · 2018-01-18T12:00:09Z

Yep, fallback should definitely stay (whether the angular client should go or not seems to be a different debate).

maxidorius · 2018-01-18T12:06:33Z

@dbkr I don't understand how this should end up then. Should the endpoint still exist but can return a page which is not a client, or no data at all? or should there always be a client, just not the angular client?

krombel · 2018-01-18T12:59:16Z

@dbkr I do not really understand what the purpose of leaving the login client is.
It is commonly advised to not use the buildin client and preferably go for other clients...

t3chguy · 2018-01-18T13:14:32Z

@krombel the login client is not part of the obsolete client aiui
the login client is a way for clients which don't support password login for whatever reason to still be able to get an access token by just throwing their user at it

erikjohnston · 2018-01-18T14:38:26Z

The "login client" isn't really a client at all, its just a web page that can be embedded in a client to do the login flows. This makes it possible to login with any client even if the server has some obscure custom login flows which few clients support.

Without this fallback mechanism clients wouldn't be able to login to servers that require custom login flows that the client doesn't understand.

Requested changes made

dbkr · 2018-01-18T15:59:23Z

Yep, what @t3chguy and @erikjohnston said. This looks better. This is becoming much less my area of expertise now, but other potential things which may or may not be worth worrying about:

The 'congratulations' page is nice as a first thing the user sees, but making every synapse host it with no way to disable it feels a bit strange to me. It's much like the Apache default page, but of course that would normally get replaced with your content.
If there are links to rooms in the software itself, it feels like they ought to be official project rooms

…ebclient

When this setting is set to true we have a redirect from `/` to ´STATIC_PREFIX`. If set to false a call to / will return with "No Resource"

andrewshadura · 2018-06-07T06:10:41Z

This will also solve #~~1932~~ and probably also #~~1561~~ and #~~2368~~.

andrewshadura · 2018-06-07T06:16:12Z

Is there anything that’s blocking this PR from being merged? I guess non-critical issues can be fixed incrementally in separate PRs.

richvdh · 2018-06-07T08:54:11Z

Just tuits to look at it properly. It's unlikely it will solve the captcha freedom issues, fwiw

andrewshadura · 2018-06-07T09:45:10Z

Why? The captcha is related to the webclient, if it’s removed, the recaptcha.js will also go away?

t3chguy · 2018-06-07T09:46:17Z

@andrewshadura its probably used in the fallback login client
https://matrix.org/speculator/spec/HEAD/client_server/unstable.html#fallback
(which is shown by clients which wish not to directly house the recaptcha)

andrewshadura · 2018-06-07T09:50:39Z

Right, so if reCAPTCHA has to be used, can we dynamically load it and not ship the minified source instead?

richvdh · 2018-06-07T10:32:47Z

Why? The captcha is related to the webclient, if it’s removed, the recaptcha.js will also go away?

recaptcha is part of the spec: https://matrix.org/docs/spec/client_server/r0.3.0.html#google-recaptcha. Removing support from synapse will not fix that, which is the subject of #1561 aiui. (on the other hand, that makes it a spec issue, not a synapse issue: updated accordingly).

Right, so if reCAPTCHA has to be used, can we dynamically load it and not ship the minified source instead?

almost certainly. Definitely an orthogonal problem though, and the subject of #1932, aiui.

@krombel

This is based on the work done by @krombel in #2601.

@krombel

This is largely a precursor for the removal of the bundled webclient. The idea is to present a page at / which reassures people that something is working, and to give them some links for next steps. The welcome page lives at `/_matrix/static/`, so is enabled alongside the other `static` resources (which, in practice, means the client API is enabled). We'll redirect to it from `/` if we have nothing better to display there. It would be nice to have a way to disable it (in the same way that you might disable the nginx welcome page), but I can't really think of a good way to do that without a load of ickiness. It's based on the work done by @krombel for #2601.

richvdh · 2018-12-11T15:27:48Z

superceded by #4289 / #4290. Thank you for your work on this @krombel !

krombel · 2018-12-11T15:37:47Z

Thanks for finally handling it 😏

remove obsolete webclient as requested in matrix-org#1527

21dee5e

remove more unused code (e.g. RootRedirect)

554e3a2

krombel added 7 commits November 6, 2017 12:18

Merge branch 'develop' into remove_buildin_webclient

162f847

fix merge

2169b26

add a static page for /

9d068ae

remove static files for another old webclient

a3990fe

add CSS to synapse homepage; reformat

01c83e6

shorten log-output to satisfy pep8 test

243c50f

Merge remote-tracking branch 'upstream/develop' into remove_buildin_w…

eeb9cb4

…ebclient

t3chguy reviewed Jan 16, 2018

View reviewed changes

change wording of welcome page according to comments

28744e8

dbkr previously requested changes Jan 18, 2018

View reviewed changes

restore client directory

606b490

krombel added 3 commits March 28, 2018 16:07

update welcome page to refer to view.matrix.org

090e771

Merge remote-tracking branch 'upstream/develop' into remove_buildin_w…

f1bcd4f

…ebclient

add config.redirect_root_to_static to allow disabling redirect

7110023

When this setting is set to true we have a redirect from `/` to ´STATIC_PREFIX`. If set to false a call to / will return with "No Resource"

aaronraimist mentioned this pull request Dec 4, 2018

Fix web_client config option #4258

Closed

Merge branch 'develop' into remove_buildin_webclient

33acc8c

richvdh mentioned this pull request Dec 11, 2018

Add a welcome page to the static resources #4289

Merged

richvdh added a commit that referenced this pull request Dec 11, 2018

Stop installing Matrix Console by default

df96177

This is based on the work done by @krombel in #2601.

richvdh mentioned this pull request Dec 11, 2018

Stop installing Matrix Console by default #4290

Merged

richvdh closed this Dec 11, 2018

krombel deleted the remove_buildin_webclient branch December 11, 2018 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove obsolete webclient #2601

remove obsolete webclient #2601

krombel commented Oct 28, 2017 •

edited

Loading

matrixbot commented Oct 28, 2017

matrixbot commented Oct 28, 2017

maxidorius commented Oct 28, 2017

turt2live commented Oct 29, 2017

krombel commented Oct 30, 2017

maxidorius commented Oct 30, 2017

krombel commented Oct 30, 2017

maxidorius commented Oct 30, 2017

turt2live commented Dec 18, 2017

krombel commented Jan 16, 2018

t3chguy Jan 16, 2018

t3chguy Jan 16, 2018

dbkr left a comment

krombel commented Jan 18, 2018 •

edited

Loading

dbkr commented Jan 18, 2018

maxidorius commented Jan 18, 2018

krombel commented Jan 18, 2018

t3chguy commented Jan 18, 2018

erikjohnston commented Jan 18, 2018

dbkr commented Jan 18, 2018

andrewshadura commented Jun 7, 2018 •

edited

Loading

andrewshadura commented Jun 7, 2018

richvdh commented Jun 7, 2018

andrewshadura commented Jun 7, 2018

t3chguy commented Jun 7, 2018 •

edited

Loading

andrewshadura commented Jun 7, 2018

richvdh commented Jun 7, 2018 •

edited

Loading

richvdh commented Dec 11, 2018 •

edited

Loading

krombel commented Dec 11, 2018

remove obsolete webclient #2601

remove obsolete webclient #2601

Conversation

krombel commented Oct 28, 2017 • edited Loading

matrixbot commented Oct 28, 2017

matrixbot commented Oct 28, 2017

maxidorius commented Oct 28, 2017

turt2live commented Oct 29, 2017

krombel commented Oct 30, 2017

maxidorius commented Oct 30, 2017

krombel commented Oct 30, 2017

maxidorius commented Oct 30, 2017

turt2live commented Dec 18, 2017

krombel commented Jan 16, 2018

t3chguy Jan 16, 2018

Choose a reason for hiding this comment

t3chguy Jan 16, 2018

Choose a reason for hiding this comment

dbkr left a comment

Choose a reason for hiding this comment

krombel commented Jan 18, 2018 • edited Loading

dbkr commented Jan 18, 2018

maxidorius commented Jan 18, 2018

krombel commented Jan 18, 2018

t3chguy commented Jan 18, 2018

erikjohnston commented Jan 18, 2018

dbkr commented Jan 18, 2018

andrewshadura commented Jun 7, 2018 • edited Loading

andrewshadura commented Jun 7, 2018

richvdh commented Jun 7, 2018

andrewshadura commented Jun 7, 2018

t3chguy commented Jun 7, 2018 • edited Loading

andrewshadura commented Jun 7, 2018

richvdh commented Jun 7, 2018 • edited Loading

richvdh commented Dec 11, 2018 • edited Loading

krombel commented Dec 11, 2018

krombel commented Oct 28, 2017 •

edited

Loading

krombel commented Jan 18, 2018 •

edited

Loading

andrewshadura commented Jun 7, 2018 •

edited

Loading

t3chguy commented Jun 7, 2018 •

edited

Loading

richvdh commented Jun 7, 2018 •

edited

Loading

richvdh commented Dec 11, 2018 •

edited

Loading