This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
MSC3861: m.3pid_changes
capability should be disabled
#16134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW, the approach that has been used elsewhere for MSC3861 is to error if the admin has tried to explicitly enable a feature that is not compatible with delegated auth. i.e. https://github.com/matrix-org/synapse/blob/develop/synapse/config/experimental.py#L151 I was intended to write a PR for this myself which did:
|
erikjohnston
added
the
X-Release-Blocker
Must be resolved before making a release
label
Aug 21, 2023
clokep
previously requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @hughns's review.
MatMaul
force-pushed
the
mv/delegate-auth-disable-3pid-changes
branch
from
August 22, 2023 12:11
e049888
to
5b146fc
Compare
hughns
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
clokep
reviewed
Aug 22, 2023
I combined the news file with #16127. |
clokep
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16128.
Pull Request Checklist
(run the linters)