Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Drop Debian Buster since we no longer support Python 3.7 #15893

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Drop Debian Buster since we no longer support Python 3.7 #15893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd5e312
drop debian buster
H-Shay Jul 7, 2023
202029d
newsfragment
H-Shay Jul 7, 2023
7f08789
update comment
H-Shay Jul 10, 2023
a8580ba
update comment
H-Shay Jul 10, 2023
83ca347
Update changelog.d/15893.misc
H-Shay Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/twisted_trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ jobs:
if: needs.check_repo.outputs.should_run_workflow == 'true'
runs-on: ubuntu-latest
container:
image: matrixdotorg/sytest-synapse:buster
# We're using ubuntu:focal because it uses Python 3.8 which is our minimum supported Python version.
# This job is a canary to warn us about unreleased twisted changes that would cause problems for us if
# they were to be released immediately. For simplicity's sake (and to save CI runners) we use the oldest
# version, assuming that any incompatibilities on newer versions would also be present on the oldest.
image: matrixdotorg/sytest-synapse:focal
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved
volumes:
- ${{ github.workspace }}:/src

Expand Down
1 change: 1 addition & 0 deletions changelog.d/15893.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop Debian Buster since we no longer support Python 3.7.
2 changes: 1 addition & 1 deletion docs/deprecation_policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ people building from source should ensure they can fetch recent versions of Rust
(e.g. by using [rustup](https://rustup.rs/)).

The oldest supported version of SQLite is the version
[provided](https://packages.debian.org/buster/libsqlite3-0) by
[provided](https://packages.debian.org/bullseye/libsqlite3-0) by
[Debian oldstable](https://wiki.debian.org/DebianOldStable).

Context
Expand Down
2 changes: 1 addition & 1 deletion docs/development/contributing_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ The following command will let you run the integration test with the most common
configuration:

```sh
$ docker run --rm -it -v /path/where/you/have/cloned/the/repository\:/src:ro -v /path/to/where/you/want/logs\:/logs matrixdotorg/sytest-synapse:buster
$ docker run --rm -it -v /path/where/you/have/cloned/the/repository\:/src:ro -v /path/to/where/you/want/logs\:/logs matrixdotorg/sytest-synapse:focal
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved
```
(Note that the paths must be full paths! You could also write `$(realpath relative/path)` if needed.)

Expand Down
1 change: 0 additions & 1 deletion scripts-dev/build_debian_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
# These are expanded inside the dockerfile to be a fully qualified image name.
# e.g. docker.io/library/debian:bullseye
DISTS = (
"debian:buster", # oldstable: EOL 2022-08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this fixes failures we're seeing in CI like https://github.com/matrix-org/synapse/actions/runs/5484040336/jobs/9991067272

ERROR: Package 'matrix-synapse' requires a different Python: 3.7.13 not in '<4.0.0,>=3.8.0'

...

Error: Command ['pip', 'install', '/tmp/cibuildwheel/repaired_wheel/matrix_synapse-1.87.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl'] failed with code 1.

(notice how it's trying to run with an image called cp37 because that's what Debian Buster has but we dropped support for Python 3.7 already)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a follow-up PR to document the distribution EOL date and EOL date forced by the Python version that each distribtion uses -> #15909

This way the connection is more obvious and hopefully we can catch this next time we want to remove a Python version.

"debian:bullseye",
"debian:bookworm",
"debian:sid",
Expand Down